From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 058F01B248 for ; Fri, 6 Oct 2017 08:43:59 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0E3C481DE7; Fri, 6 Oct 2017 06:43:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0E3C481DE7 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=maxime.coquelin@redhat.com Received: from [10.36.112.35] (ovpn-112-35.ams2.redhat.com [10.36.112.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4B4ED619F6; Fri, 6 Oct 2017 06:43:58 +0000 (UTC) To: Olivier Matz , dev@dpdk.org References: <20170911151333.5727-1-olivier.matz@6wind.com> <20170911151333.5727-4-olivier.matz@6wind.com> From: Maxime Coquelin Message-ID: Date: Fri, 6 Oct 2017 08:43:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170911151333.5727-4-olivier.matz@6wind.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 06 Oct 2017 06:43:59 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 03/10] net/virtio: fix compilation with -Og X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Oct 2017 06:44:00 -0000 On 09/11/2017 05:13 PM, Olivier Matz wrote: > The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the following > error: > > CC virtio_rxtx.o > virtio_rxtx.c: In function ‘virtio_rx_offload’: > virtio_rxtx.c:680:10: error: ‘csum’ may be used uninitialized in > this function [-Werror=maybe-uninitialized] > csum = ~csum; > ~~~~~^~~~~~~ > > The function rte_raw_cksum_mbuf() may indeed return an error, and > in this case, csum won't be initialized. Fix it by initializing csum > to 0. > > Fixes: 96cb6711939e ("net/virtio: support Rx checksum offload") > Signed-off-by: Olivier Matz > --- > drivers/net/virtio/virtio_rxtx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c > index 45a9c919a..cab3a1675 100644 > --- a/drivers/net/virtio/virtio_rxtx.c > +++ b/drivers/net/virtio/virtio_rxtx.c > @@ -671,7 +671,7 @@ virtio_rx_offload(struct rte_mbuf *m, struct virtio_net_hdr *hdr) > * In case of SCTP, this will be wrong since it's a CRC > * but there's nothing we can do. > */ > - uint16_t csum, off; > + uint16_t csum = 0, off; > > rte_raw_cksum_mbuf(m, hdr->csum_start, > rte_pktmbuf_pkt_len(m) - hdr->csum_start, > Reviewed-by: Maxime Coquelin Thanks, Maxime