From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id E8CC04324A;
Wed, 1 Nov 2023 04:40:10 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id D55F4402CF;
Wed, 1 Nov 2023 04:40:10 +0100 (CET)
Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])
by mails.dpdk.org (Postfix) with ESMTP id 92613402B0
for <dev@dpdk.org>; Wed, 1 Nov 2023 04:40:09 +0100 (CET)
Received: from kwepemm000004.china.huawei.com (unknown [172.30.72.57])
by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4SKt3j2gymz1P7l7;
Wed, 1 Nov 2023 11:37:05 +0800 (CST)
Received: from [10.67.121.59] (10.67.121.59) by kwepemm000004.china.huawei.com
(7.193.23.18) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Wed, 1 Nov
2023 11:40:05 +0800
Message-ID: <d1a7c3e9-3ca0-02ba-4fc9-9bf80ba4965e@huawei.com>
Date: Wed, 1 Nov 2023 11:40:04 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
Thunderbird/91.2.0
Subject: Re: [PATCH v2 2/7] net/hns3: replace fp ops config function
To: Chengwen Feng <fengchengwen@huawei.com>, <thomas@monjalon.net>,
<ferruh.yigit@amd.com>, <konstantin.ananyev@huawei.com>,
<ajit.khaparde@broadcom.com>, Jie Hai <haijie1@huawei.com>, Yisen Zhuang
<yisen.zhuang@huawei.com>
CC: <dev@dpdk.org>, <andrew.rybchenko@oktetlabs.ru>,
<kalesh-anakkur.purayil@broadcom.com>, <Honnappa.Nagarahalli@arm.com>
References: <20230301030610.49468-1-fengchengwen@huawei.com>
<20231020100746.31520-1-fengchengwen@huawei.com>
<20231020100746.31520-3-fengchengwen@huawei.com>
From: "lihuisong (C)" <lihuisong@huawei.com>
In-Reply-To: <20231020100746.31520-3-fengchengwen@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.67.121.59]
X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To
kwepemm000004.china.huawei.com (7.193.23.18)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
lgtm,
Acked-by: Huisong Li <lihuisong@huawei.com>
在 2023/10/20 18:07, Chengwen Feng 写道:
> This patch replace hns3_eth_dev_fp_ops_config() with
> rte_eth_fp_ops_setup().
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Acked-by: Dongdong Liu <liudongdong3@huawei.com>
> ---
> drivers/net/hns3/hns3_rxtx.c | 21 +++------------------
> 1 file changed, 3 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c
> index f3c3b38c55..f43f1eb9ad 100644
> --- a/drivers/net/hns3/hns3_rxtx.c
> +++ b/drivers/net/hns3/hns3_rxtx.c
> @@ -4434,21 +4434,6 @@ hns3_trace_rxtx_function(struct rte_eth_dev *dev)
> rx_mode.info, tx_mode.info);
> }
>
> -static void
> -hns3_eth_dev_fp_ops_config(const struct rte_eth_dev *dev)
> -{
> - struct rte_eth_fp_ops *fpo = rte_eth_fp_ops;
> - uint16_t port_id = dev->data->port_id;
> -
> - fpo[port_id].rx_pkt_burst = dev->rx_pkt_burst;
> - fpo[port_id].tx_pkt_burst = dev->tx_pkt_burst;
> - fpo[port_id].tx_pkt_prepare = dev->tx_pkt_prepare;
> - fpo[port_id].rx_descriptor_status = dev->rx_descriptor_status;
> - fpo[port_id].tx_descriptor_status = dev->tx_descriptor_status;
> - fpo[port_id].rxq.data = dev->data->rx_queues;
> - fpo[port_id].txq.data = dev->data->tx_queues;
> -}
> -
> void
> hns3_set_rxtx_function(struct rte_eth_dev *eth_dev)
> {
> @@ -4471,7 +4456,7 @@ hns3_set_rxtx_function(struct rte_eth_dev *eth_dev)
> }
>
> hns3_trace_rxtx_function(eth_dev);
> - hns3_eth_dev_fp_ops_config(eth_dev);
> + rte_eth_fp_ops_setup(eth_dev);
> }
>
> void
> @@ -4824,7 +4809,7 @@ hns3_stop_tx_datapath(struct rte_eth_dev *dev)
> {
> dev->tx_pkt_burst = rte_eth_pkt_burst_dummy;
> dev->tx_pkt_prepare = NULL;
> - hns3_eth_dev_fp_ops_config(dev);
> + rte_eth_fp_ops_setup(dev);
>
> if (rte_eal_process_type() == RTE_PROC_SECONDARY)
> return;
> @@ -4841,7 +4826,7 @@ hns3_start_tx_datapath(struct rte_eth_dev *dev)
> {
> dev->tx_pkt_burst = hns3_get_tx_function(dev);
> dev->tx_pkt_prepare = hns3_get_tx_prepare(dev);
> - hns3_eth_dev_fp_ops_config(dev);
> + rte_eth_fp_ops_setup(dev);
>
> if (rte_eal_process_type() == RTE_PROC_SECONDARY)
> return;