From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 6E079A057C;
Fri, 27 Mar 2020 12:45:06 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 45B511C122;
Fri, 27 Mar 2020 12:45:06 +0100 (CET)
Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com
[209.85.128.66]) by dpdk.org (Postfix) with ESMTP id B7BB21C10E
for <dev@dpdk.org>; Fri, 27 Mar 2020 12:45:04 +0100 (CET)
Received: by mail-wm1-f66.google.com with SMTP id e9so54517wme.4
for <dev@dpdk.org>; Fri, 27 Mar 2020 04:45:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=accelercomm-com.20150623.gappssmtp.com; s=20150623;
h=subject:to:references:from:message-id:date:user-agent:mime-version
:in-reply-to:content-transfer-encoding:content-language;
bh=uAawucY/UGwwqo7sY18/GNg457fyOB0wLWGQNx5j+gE=;
b=TwGEhTRBTtpXZ4Su96RzXWA9qxDDfivxZxPj2CfMrr2XtzKgqctcwndoHAzlqPtBuz
AqAJ0fKObENdjwokiaWRdKsgfFis8vrMh+5IQ/BetyBquHWHgXZnB/L7ew+mdgi6eRwv
5fdT8E5glsBwK8gKj9tkvLzvWIbYdkNkLmclnZVlEZtz721g2EGnqQt6/WmAufZlo2yM
j45PbIe/n1Hx/KNQTCypqsnxrXJ5DHyInqpoYlRO5a0bDJOJ+Agpq+5A2nhIs7ANfAQH
6p1WMdFBJwJrfm0vTYT8PDX08CfgbixLqk8LPs5SXlBrcfLdsrEmTQfxfvD2iqrFAuBI
OiJQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:subject:to:references:from:message-id:date
:user-agent:mime-version:in-reply-to:content-transfer-encoding
:content-language;
bh=uAawucY/UGwwqo7sY18/GNg457fyOB0wLWGQNx5j+gE=;
b=OFGdzTnpVab8QLpb+ms2VJr0T8LKrcaMNybq4G8v8ubZ1zvxFV0Ssvt1FYy9KdHNGX
gfICQ3FSoAL9OrWo9KkMoi+nxndbgl+NKhlYrkt6sF21QkYK+UmjmsmbRE3DTOgk87oS
jSLfuTwLyhetvCS3Uih7bPdpCkhZlZaYVfjLSV8+kY6QBTGkp/MrZZE/FDNeY15svhKt
WkbYYup/bnC/g6P4buGRrLCqxV/IjHHyLiuKCjCo+ulNnpaGNLmKQ19sNEaR3Z2qrJFT
czPIFQcbJ4hFw3YOwnDrF6J7nxVY3TWfY9/Ie6deMSRjkSB235T/M4cr1WgerLlJUp/8
5z7w==
X-Gm-Message-State: ANhLgQ25gGqUwFKnU+vmWF2lrplgKnAiqtac/1yxP8dOKtdsMMBrkm/p
uluonyTkxCdOAS+x4IDeWP5zH+Ejt+s=
X-Google-Smtp-Source: ADFU+vvA5fRrHHfOpC5jYMvZOwD+Md3RN5dH0e4ATMwkfDSiAdBbIElYs+eyQWjZJDw2indVVGhMCw==
X-Received: by 2002:a7b:c448:: with SMTP id l8mr5326491wmi.128.1585309504197;
Fri, 27 Mar 2020 04:45:04 -0700 (PDT)
Received: from ?IPv6:2a00:23c4:cf2d:a200:6023:b810:2491:c6a9?
([2a00:23c4:cf2d:a200:6023:b810:2491:c6a9])
by smtp.gmail.com with ESMTPSA id y187sm8024280wmd.0.2020.03.27.04.45.03
for <dev@dpdk.org>
(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
Fri, 27 Mar 2020 04:45:03 -0700 (PDT)
To: dev@dpdk.org
References: <1582778348-113547-15-git-send-email-nicolas.chautru@intel.com>
<1585193268-74468-1-git-send-email-nicolas.chautru@intel.com>
<1585193268-74468-3-git-send-email-nicolas.chautru@intel.com>
From: Dave Burley <dave.burley@accelercomm.com>
Message-ID: <d1bb059b-873a-786f-928b-a1a1ece60521@accelercomm.com>
Date: Fri, 27 Mar 2020 11:45:03 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <1585193268-74468-3-git-send-email-nicolas.chautru@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH v5 02/10] bbdev: expose device HARQ buffer
size at device level
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Acked-by: Dave Burley <dave.burley@accelercomm.com>
On 26/03/2020 03:27, Nicolas Chautru wrote:
> From: Nic Chautru <nicolas.chautru@intel.com>
>
> This exposes the HARQ buffer size at the device driver level
> instead of using the capability of a specific operation.
>
> This is currently not yet used by a device until
> future commit.
>
> Signed-off-by: Nic Chautru <nicolas.chautru@intel.com>
> ---
> drivers/baseband/turbo_sw/bbdev_turbo_software.c | 2 +-
> lib/librte_bbdev/rte_bbdev.h | 2 ++
> lib/librte_bbdev/rte_bbdev_op.h | 2 --
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
> index f2fe7a2..6d5e080 100644
> --- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c
> +++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
> @@ -219,7 +219,6 @@ struct turbo_sw_queue {
> RTE_BBDEV_LDPC_ITERATION_STOP_ENABLE,
> .llr_size = 8,
> .llr_decimals = 2,
> - .harq_memory_size = 0,
> .num_buffers_src =
> RTE_BBDEV_LDPC_MAX_CODE_BLOCKS,
> .num_buffers_hard_out =
> @@ -251,6 +250,7 @@ struct turbo_sw_queue {
> dev_info->default_queue_conf = default_queue_conf;
> dev_info->capabilities = bbdev_capabilities;
> dev_info->min_alignment = 64;
> + dev_info->harq_buffer_size = 0;
>
> rte_bbdev_log_debug("got device info from %u\n", dev->data->dev_id);
> }
> diff --git a/lib/librte_bbdev/rte_bbdev.h b/lib/librte_bbdev/rte_bbdev.h
> index b2da190..38d9d50 100644
> --- a/lib/librte_bbdev/rte_bbdev.h
> +++ b/lib/librte_bbdev/rte_bbdev.h
> @@ -307,6 +307,8 @@ struct rte_bbdev_driver_info {
> bool queue_intr_supported;
> /** Minimum alignment of buffers, in bytes */
> uint16_t min_alignment;
> + /** HARQ memory available in kB */
> + uint32_t harq_buffer_size;
> /** Default queue configuration used if none is supplied */
> struct rte_bbdev_queue_conf default_queue_conf;
> /** Device operation capabilities */
> diff --git a/lib/librte_bbdev/rte_bbdev_op.h b/lib/librte_bbdev/rte_bbdev_op.h
> index c8a354e..80f3934 100644
> --- a/lib/librte_bbdev/rte_bbdev_op.h
> +++ b/lib/librte_bbdev/rte_bbdev_op.h
> @@ -712,8 +712,6 @@ struct rte_bbdev_op_cap_ldpc_dec {
> int8_t llr_size;
> /** LLR numbers of decimals bit for arithmetic representation */
> int8_t llr_decimals;
> - /** Amount of memory for HARQ in external DDR in MB */
> - uint16_t harq_memory_size;
> /** Num input code block buffers */
> uint16_t num_buffers_src;
> /** Num hard output code block buffers */