* [dpdk-dev] [PATCH] net/cxgbe: report configured link auto-negotiation
@ 2018-05-23 18:00 Rahul Lakkireddy
2018-05-24 17:18 ` Ferruh Yigit
2018-05-31 16:47 ` Ferruh Yigit
0 siblings, 2 replies; 3+ messages in thread
From: Rahul Lakkireddy @ 2018-05-23 18:00 UTC (permalink / raw)
To: dev; +Cc: shaguna, kumaras, nirranjan, indranil
Report current configured link auto-negotiation. Also initialize
rte_eth_link.
Coverity issue: 280648
Fixes: f5b3c7b29357 ("net/cxgbevf: fix inter-VM traffic when physical link down")
Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
---
drivers/net/cxgbe/cxgbe_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c
index 61115e26a..32450915c 100644
--- a/drivers/net/cxgbe/cxgbe_ethdev.c
+++ b/drivers/net/cxgbe/cxgbe_ethdev.c
@@ -204,13 +204,14 @@ int cxgbe_dev_link_update(struct rte_eth_dev *eth_dev,
struct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);
struct adapter *adapter = pi->adapter;
struct sge *s = &adapter->sge;
- struct rte_eth_link new_link;
+ struct rte_eth_link new_link = { 0 };
unsigned int work_done, budget = 4;
cxgbe_poll(&s->fw_evtq, NULL, budget, &work_done);
new_link.link_status = force_linkup(adapter) ?
ETH_LINK_UP : pi->link_cfg.link_ok;
+ new_link.link_autoneg = pi->link_cfg.autoneg;
new_link.link_duplex = ETH_LINK_FULL_DUPLEX;
new_link.link_speed = pi->link_cfg.speed;
--
2.14.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/cxgbe: report configured link auto-negotiation
2018-05-23 18:00 [dpdk-dev] [PATCH] net/cxgbe: report configured link auto-negotiation Rahul Lakkireddy
@ 2018-05-24 17:18 ` Ferruh Yigit
2018-05-31 16:47 ` Ferruh Yigit
1 sibling, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-05-24 17:18 UTC (permalink / raw)
To: Rahul Lakkireddy, dev; +Cc: shaguna, kumaras, nirranjan, indranil
On 5/23/2018 7:00 PM, Rahul Lakkireddy wrote:
> Report current configured link auto-negotiation. Also initialize
> rte_eth_link.
>
> Coverity issue: 280648
> Fixes: f5b3c7b29357 ("net/cxgbevf: fix inter-VM traffic when physical link down")
>
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Will postpone to next release, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/cxgbe: report configured link auto-negotiation
2018-05-23 18:00 [dpdk-dev] [PATCH] net/cxgbe: report configured link auto-negotiation Rahul Lakkireddy
2018-05-24 17:18 ` Ferruh Yigit
@ 2018-05-31 16:47 ` Ferruh Yigit
1 sibling, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-05-31 16:47 UTC (permalink / raw)
To: Rahul Lakkireddy, dev; +Cc: shaguna, kumaras, nirranjan, indranil
On 5/23/2018 7:00 PM, Rahul Lakkireddy wrote:
> Report current configured link auto-negotiation. Also initialize
> rte_eth_link.
>
> Coverity issue: 280648
> Fixes: f5b3c7b29357 ("net/cxgbevf: fix inter-VM traffic when physical link down")
>
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-31 16:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-23 18:00 [dpdk-dev] [PATCH] net/cxgbe: report configured link auto-negotiation Rahul Lakkireddy
2018-05-24 17:18 ` Ferruh Yigit
2018-05-31 16:47 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).