DPDK patches and discussions
 help / color / mirror / Atom feed
From: Анатолий Дубинский <ard@amicon.ru>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: "xavier.huwei@huawei.com" <xavier.huwei@huawei.com>
Subject: Re: [dpdk-dev] small error in rte_eth_bond_api.c
Date: Tue, 14 Jul 2020 15:14:57 +0000
Message-ID: <d1e04f4a6b2541248035f690fcc56743@amicon.ru> (raw)
In-Reply-To: <f46953b6d870425da11e227a6600812d@amicon.ru>

Hello!

I've found a small error in .../drivers/net/bonding/rte_eth_bond_api.c :

Func rte_eth_bond_create:
ret = rte_vdev_init(name, devargs);
if (ret)
  return -ENOMEM;


So, we get ENOMEM error regardless of the actual error code.

This code would be more applicable.
ret = rte_vdev_init(name, devargs);
if (ret)
  return ret;


Reported-by: Anatoly Dubinsky, ard@amicon.ru



________________________________
От: Анатолий Дубинский
Отправлено: 19 июня 2020 г. 21:12
Кому: dev@dpdk.org
Тема: small error in rte_eth_bond_api.c


Hello!

I've found a small error in .../drivers/net/bonding/rte_eth_bond_api.c :

Func rte_eth_bond_create:
ret = rte_vdev_init(name, devargs);
if (ret)
return -ENOMEM;

So, we get ENOMEM error regardless of the actual error code.

This code would be more applicable.
ret = rte_vdev_init(name, devargs);
if (ret)
return ret;


Yours sincerely, Anatoly Dubinsky.



      parent reply	other threads:[~2020-07-17 10:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-19 18:12 Анатолий Дубинский
2020-06-22  8:42 ` Wei Hu (Xavier)
2020-07-14 15:14 ` Анатолий Дубинский [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d1e04f4a6b2541248035f690fcc56743@amicon.ru \
    --to=ard@amicon.ru \
    --cc=dev@dpdk.org \
    --cc=xavier.huwei@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git