From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id D07BE1B4FB; Thu, 29 Nov 2018 16:36:58 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Nov 2018 07:36:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,295,1539673200"; d="scan'208";a="106776250" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.109]) ([10.237.220.109]) by FMSMGA003.fm.intel.com with ESMTP; 29 Nov 2018 07:36:57 -0800 To: dev@dpdk.org Cc: stable@dpdk.org References: From: "Burakov, Anatoly" Message-ID: Date: Thu, 29 Nov 2018 15:36:56 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] malloc: fix duplicate mem event notification X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 15:36:59 -0000 On 29-Nov-18 3:18 PM, Anatoly Burakov wrote: > We already trigger a mem event notification inside the walk function, > no need to do it twice. > > Fixes: f32c7c9de961 ("malloc: enable event callbacks for external memory") > Cc: stable@dpdk.org > > Signed-off-by: Anatoly Burakov > --- > lib/librte_eal/common/rte_malloc.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/lib/librte_eal/common/rte_malloc.c b/lib/librte_eal/common/rte_malloc.c > index 0da5ad5e8..750a83c2c 100644 > --- a/lib/librte_eal/common/rte_malloc.c > +++ b/lib/librte_eal/common/rte_malloc.c > @@ -518,10 +518,6 @@ sync_memory(const char *heap_name, void *va_addr, size_t len, bool attach) > rte_errno = -wa.result; > ret = -1; > } else { > - /* notify all subscribers that a new memory area was added */ > - if (attach) > - eal_memalloc_mem_event_notify(RTE_MEM_EVENT_ALLOC, > - va_addr, len); > ret = 0; > } > unlock: > Oops, dupe. -- Thanks, Anatoly