[dpdk-dev] [PATCH v1] net/ice: add invalid RSS combinations

[dpdk-dev] [PATCH v1] net/ice: add invalid RSS combinations

[Liulingyu]

When create a rule with following invalid RSS type combinations,
it should fails.

Invalid RSS combinations list:
- ETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_TCP
- ETH_RSS_IPV6 | ETH_RSS_NONFRAG_IPV6_TCP

This patch adds these combinations in 'invalid_rss_comb' array to
do valid check, if the combination check failed, the rule will be
created failed.

Signed-off-by: Liulingyu <lingyu.liu@intel.com>
---
 drivers/net/ice/ice_hash.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c
index 7d7e7052da..e56cdf9941 100644
--- a/drivers/net/ice/ice_hash.c
+++ b/drivers/net/ice/ice_hash.c
@@ -826,7 +826,9 @@ static void ice_refine_hash_cfg(struct ice_rss_hash_cfg *hash_cfg,
 
 static uint64_t invalid_rss_comb[] = {
 	ETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_UDP,
+	ETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_TCP,
 	ETH_RSS_IPV6 | ETH_RSS_NONFRAG_IPV6_UDP,
+	ETH_RSS_IPV6 | ETH_RSS_NONFRAG_IPV6_TCP,
 	RTE_ETH_RSS_L3_PRE40 |
 	RTE_ETH_RSS_L3_PRE56 |
 	RTE_ETH_RSS_L3_PRE96
-- 
2.25.1

Re: [dpdk-dev] [PATCH v1] net/ice: add invalid RSS combinations

[Zhang, Qi Z]

> -----Original Message-----
> From: Liu, Lingyu <lingyu.liu@intel.com>
> Sent: Thursday, April 8, 2021 11:55 PM
> To: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Cc: Liu, Lingyu <lingyu.liu@intel.com>
> Subject: [PATCH v1] net/ice: add invalid RSS combinations
> 
> When create a rule with following invalid RSS type combinations, it should
> fails.
> 
> Invalid RSS combinations list:
> - ETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_TCP
> - ETH_RSS_IPV6 | ETH_RSS_NONFRAG_IPV6_TCP
> 
> This patch adds these combinations in 'invalid_rss_comb' array to do valid
> check, if the combination check failed, the rule will be created failed.
> 
> Signed-off-by: Liulingyu <lingyu.liu@intel.com>

Renamed to "Lingyu Liu <lingyu.liu@intel.com>" to align with the required format.

Acked: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi