DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] crypto/aesni_mb: fix missed wrapping
@ 2018-12-18 14:03 Fan Zhang
  2018-12-18 15:18 ` Akhil Goyal
  0 siblings, 1 reply; 2+ messages in thread
From: Fan Zhang @ 2018-12-18 14:03 UTC (permalink / raw)
  To: dev; +Cc: akhil.goyal

This patch fixes the missed macro check of intel-ipsec-mb version.
Since plain SHA is supported only in 0.52, without a marco to
wrap the newly introduced definitions will cause the failed
compile if intel-ipsec-mb older than 0.52 is installed.

Fixes: 9d8dd0c5af95 ("crypto/aesni_mb: support plain sha")

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h
index 6f4f5eeea..781d3ea31 100644
--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h
+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h
@@ -109,11 +109,13 @@ static const unsigned auth_digest_byte_lengths[] = {
 		[AES_CMAC]	= 16,
 		[AES_GMAC]	= 12,
 		[NULL_HASH]	= 0,
+#if IMB_VERSION_NUM >= IMB_VERSION(0, 52, 0)
 		[PLAIN_SHA1] 	= 20,
 		[PLAIN_SHA_224] = 28,
 		[PLAIN_SHA_256] = 32,
 		[PLAIN_SHA_384] = 48,
 		[PLAIN_SHA_512] = 64
+#endif
 	/**< Vector mode dependent pointer table of the multi-buffer APIs */
 
 };
-- 
2.13.6

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] crypto/aesni_mb: fix missed wrapping
  2018-12-18 14:03 [dpdk-dev] [PATCH] crypto/aesni_mb: fix missed wrapping Fan Zhang
@ 2018-12-18 15:18 ` Akhil Goyal
  0 siblings, 0 replies; 2+ messages in thread
From: Akhil Goyal @ 2018-12-18 15:18 UTC (permalink / raw)
  To: Fan Zhang, dev



On 12/18/2018 7:33 PM, Fan Zhang wrote:
> This patch fixes the missed macro check of intel-ipsec-mb version.
> Since plain SHA is supported only in 0.52, without a marco to
> wrap the newly introduced definitions will cause the failed
> compile if intel-ipsec-mb older than 0.52 is installed.
>
> Fixes: 9d8dd0c5af95 ("crypto/aesni_mb: support plain sha")
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>
merged with original commit on dpdk-next-crypto

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-12-18 15:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-18 14:03 [dpdk-dev] [PATCH] crypto/aesni_mb: fix missed wrapping Fan Zhang
2018-12-18 15:18 ` Akhil Goyal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).