From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45FDDA0351; Thu, 6 Aug 2020 13:58:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A650C2BF1; Thu, 6 Aug 2020 13:58:49 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 1930129D2 for ; Thu, 6 Aug 2020 13:58:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596715127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=cv/UiyyLDkOIhMazY0SQsk/gKtQBUGjCkgIZodyjqZw=; b=W/EM3TV+rd7IVbWzwHdd73lGms1yLCBl9k+5b7SFgEgi/0LzjpoZMQ+Fr1w3ai7vCxe6xY Bd65zR1a0cGVCcbgE+pzIKNtVgbvQSmFL9QW90q2RQ2h1gfpt2bYHd1VVxeq83ebRlZUuh Qv1I3gQpmsWT8n7o/zRBjM0G3V4cIV8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-23-lfmo0z59NOejuUaxIipdaw-1; Thu, 06 Aug 2020 07:58:45 -0400 X-MC-Unique: lfmo0z59NOejuUaxIipdaw-1 Received: by mail-wm1-f69.google.com with SMTP id i15so3485319wmb.5 for ; Thu, 06 Aug 2020 04:58:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=cv/UiyyLDkOIhMazY0SQsk/gKtQBUGjCkgIZodyjqZw=; b=ZZmeH9attIhan7R1al+RRuWMsu2LlM+zNTKoNXDs70cj16xtyPf9ogsDzh0PEDgg66 fOagiT3E8nG/01yhzWCL7t86Wh3uG2XpzG0DJlo+dbt1msOEaHf03KgRwpeUK1Rt/A0W DTeIEAoRD5a8OpqrXRqeE8JzyCFHPPc8/YaP+7Tj6yBMz3qRnXN5cFiCaSBOYE3fSyGN dInna/vFU3RCiWPDbem4LsYErrHXO9WfaVikw/Xaqbr6+iBWvsRMiIeMvrc6m9zQNI+l FnmmxKWZaUtL+f0IbgC3pAE/zDqQn1sC1/IHAEX1wwds87nwdyFfEBC53Z8drOxO8kxE 5AlQ== X-Gm-Message-State: AOAM532JZ/4ghTkc4n9i0AvAk5wYE8SK52TzQn2/67wA2IsCcG93cM9x /z/jwQiehdOvyx/5Lc9YNyKcfiVt4vccdWVv3vqWal8CLArj2HAq2lLAxnyvWeV8r6GNFRoeB0S bwWo= X-Received: by 2002:a7b:c316:: with SMTP id k22mr7472873wmj.41.1596715124665; Thu, 06 Aug 2020 04:58:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJznQ5FL+MTHTIiD27p+bMi1Z1wCgcIWW8MM/o7s/wGNe0Sn10Xl8u6PWf8k2s4jiZDKsfXEOg== X-Received: by 2002:a7b:c316:: with SMTP id k22mr7472860wmj.41.1596715124461; Thu, 06 Aug 2020 04:58:44 -0700 (PDT) Received: from amorenoz.users.ipa.redhat.com ([94.73.63.18]) by smtp.gmail.com with ESMTPSA id e16sm6213239wrx.30.2020.08.06.04.58.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2020 04:58:43 -0700 (PDT) To: Chenbo Xia , dev@dpdk.org Cc: maxime.coquelin@redhat.com, zhihong.wang@intel.com References: <20200806113455.82766-1-chenbo.xia@intel.com> From: Adrian Moreno Autocrypt: addr=amorenoz@redhat.com; prefer-encrypt=mutual; keydata= mQENBF1syNUBCADQ9dk3fDMxOZ/+OQpmbanpodYxEv8IRtDz8PXw8YX7UyGfozOpLjQ8Fftj ZxuubYNbt2QVbSgviFilFdNWu2eTnN/JaGtfhmTOLPVoakkPHZF8lbgImMoch7L0fH8wN2IM KPxQyPNlX+K9FD5brHsV1lfe1TwAxmhcvLW8yNrVq+9eDIDykxc7tH4exIqXgZroahGxMHKy c8Ti2kJka/t6pDfRaY0J+6J7I1nrn6GXXSMNA45EH8+0N/QlcXhP3rfftnoPeVmpjswzvJqY FNjf/Q5VPLx7RX0Qx+y8mMB2JcChV5Bl7D7x5EUbItj6+Sy7QfOgCtPegk9HSrBCNYaLABEB AAG0I0FkcmlhbiBNb3Jlbm8gPGFtb3Jlbm96QHJlZGhhdC5jb20+iQFUBBMBCAA+FiEEogUD gihhmbOPHy26d5C5fbYeFsUFAl1syNUCGwMFCQHhM4AFCwkIBwIGFQoJCAsCBBYCAwECHgEC F4AACgkQd5C5fbYeFsX7qwgArGHSkX+ILNcujkVzjTG4OtkpJMPFlkn/1PxSEKD0jLuzx14B COzpg/Mqj3Re/QBuOas+ci9bsUA0/2nORtmmEBvzDOJpR5FH1jaGCx8USlY4WM6QqEDNZgTw hsy9KhjFzFjMk+oo3HyItXA+Uq9yrRBTjNBGTXxezMRcMuUZ4MIAfY0IRBglL2BufiuL43jD BvTENNFLoQ/wFV7qkFWSkv+8IjTsxr7M6XUo1QLd29Hn0dvwssN579HL1+BP46i2REpzeBEG L75iVChi+YnIQQNMJ9NYarVabZx4Y1Gn8+7B/1SNArDV+IDgnYgt7E58otoV2Ap310dmtuvE VbxGpbkBDQRdbMjVAQgAqyp9oA7WDu7/Y9T4Ommt69iZx8os7shUIfdgPEy5xrcPn6qGwN1/ HQ4j8nWfBG9uuX1X0RXUZIUEtYTxtED4yaCQMTqDUf9cBAwAA2mYxBfoiNYx8YqxM+sT0/J4 2qmDd+y+20UR4yzHE8AmIbspTzDFIJDAi+jKSR8F355z0sfW7CIMDC4ZWrPsskjEy1YN/U10 r6tRRH1kNyrCSbTG0d9MtcQO58h7DLXuzUhErB+BtG52A04t5cweIJTJC+koV5XPeilzlHnm RFoj0ncruGa9Odns21BNt3cy9wLfK+aUnWuAB1uc6bJGQPiAwjkilz7g7MBRUuIQ2Zt7HGLc SwARAQABiQE8BBgBCAAmFiEEogUDgihhmbOPHy26d5C5fbYeFsUFAl1syNUCGwwFCQHhM4AA CgkQd5C5fbYeFsUlSwf8CH+u/IXaE7WeWxwFkMaORfW8cM4q0xrL3M6yRGuQNW+kMjnrvK9U J9G+L1/5uTRbDQ/4LdoKqize8LjehA+iF6ba4t9Npikh8fLKWgaJfQ/hPhH4C3O5gWPOLTW6 ylGxiuER4CdFwQIoAMMslhFA7G+teeOKBq36E+1+zrybI6Xy1UBSlpDK9j4CtTnMQejjuSQb Qhle+l8VroaUHq869wjAhRHHhqmtJKggI+OvzgQpDIwfHIDypb1BuKydi2W6cVYEALUYyCLS dTBDhzj8zR5tPCsga8J7+TclQzkWOiI2C6ZtiWrMsL/Uym3uXk5nsoc7lSj7yLd/MrBRhYfP JQ== Message-ID: Date: Thu, 6 Aug 2020 13:58:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200806113455.82766-1-chenbo.xia@intel.com> Content-Language: en-US Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=amorenoz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v1] vhost: add device reset status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/6/20 1:34 PM, Chenbo Xia wrote: > vhost lib now does not have definition of reset status. This patch > adds the reset status definiton and changes related log. > > Signed-off-by: Chenbo Xia > --- > lib/librte_vhost/vhost.h | 1 + > lib/librte_vhost/vhost_user.c | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h > index 632f66d53..73a1ed889 100644 > --- a/lib/librte_vhost/vhost.h > +++ b/lib/librte_vhost/vhost.h > @@ -239,6 +239,7 @@ struct vhost_virtqueue { > } __rte_cache_aligned; > > /* Virtio device status as per Virtio specification */ > +#define VIRTIO_DEVICE_STATUS_RESET 0x00 > #define VIRTIO_DEVICE_STATUS_ACK 0x01 > #define VIRTIO_DEVICE_STATUS_DRIVER 0x02 > #define VIRTIO_DEVICE_STATUS_DRIVER_OK 0x04 > diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c > index c3c924fae..1b520ead7 100644 > --- a/lib/librte_vhost/vhost_user.c > +++ b/lib/librte_vhost/vhost_user.c > @@ -2531,6 +2531,7 @@ vhost_user_set_status(struct virtio_net **pdev, struct VhostUserMsg *msg, > } > > VHOST_LOG_CONFIG(INFO, "New device status(0x%08x):\n" > + "\t-RESET: %u\n" > "\t-ACKNOWLEDGE: %u\n" > "\t-DRIVER: %u\n" > "\t-FEATURES_OK: %u\n" > @@ -2538,6 +2539,7 @@ vhost_user_set_status(struct virtio_net **pdev, struct VhostUserMsg *msg, > "\t-DEVICE_NEED_RESET: %u\n" > "\t-FAILED: %u\n", > dev->status, > + !!(dev->status & VIRTIO_DEVICE_STATUS_RESET), (dev->status & 0) will always be 0, right? how about (dev->status == VIRTIO_DEVICE_STATUS_RESET)? > !!(dev->status & VIRTIO_DEVICE_STATUS_ACK), > !!(dev->status & VIRTIO_DEVICE_STATUS_DRIVER), > !!(dev->status & VIRTIO_DEVICE_STATUS_FEATURES_OK), > -- Adrián Moreno