From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 23566FB25
 for <dev@dpdk.org>; Tue, 20 Dec 2016 11:26:01 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga105.fm.intel.com with ESMTP; 20 Dec 2016 02:26:01 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,378,1477983600"; d="scan'208";a="1074367895"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29])
 ([10.237.220.29])
 by orsmga001.jf.intel.com with ESMTP; 20 Dec 2016 02:26:00 -0800
To: Alejandro Lucero <alejandro.lucero@netronome.com>
References: <1482149104-40805-1-git-send-email-alejandro.lucero@netronome.com>
 <ca97eeb6-cabc-a1b4-6273-367430fdffb5@intel.com>
 <CAD+H993xLQ+N-U0LCmYWjPw_6_K9QcjhfGW=tXwpeocxBMsdfg@mail.gmail.com>
 <3dd84942-5c7b-5f3f-2760-a71f97dfcd6a@intel.com>
 <CAD+H992J5mossfmWG1wq-1YE=12uAQq-R8STX-G42vv13--GBQ@mail.gmail.com>
 <a26f9190-39ee-7f06-be07-80016f60242e@intel.com>
 <CAD+H990MEixLR3cv6kv4wa8gsCO38D+2_FBAig4-N5UBVmWr1A@mail.gmail.com>
 <CAD+H991y+h4T6OdCtYJNV4cq3wndGLxK9kkVqyGs5e_TN8Hiqg@mail.gmail.com>
Cc: dev <dev@dpdk.org>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <d25cdbc7-b4c5-3709-2d1f-0054f5071fa8@intel.com>
Date: Tue, 20 Dec 2016 10:25:59 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <CAD+H991y+h4T6OdCtYJNV4cq3wndGLxK9kkVqyGs5e_TN8Hiqg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH] nfp: extend speed capabilities advertised
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Dec 2016 10:26:02 -0000

On 12/19/2016 6:00 PM, Alejandro Lucero wrote:
> I forgot one thing: to update the features file with this new one.
> 
> I will wait for your feedback regarding the discussed problem for
> sending another version.

I think it is good to go, please send updated version.

> 

<...>

> 
>         Sorry, confused. Is it like following:
> 
>         "
>         For new FW, there is no problem, it supports the range between
>         1G - 50G,
>         and reports correct current speed.
> 
>         With old FW, device still can be set to speed range between 1G -
>         50G,
>         but it doesn't report current speed correct, and DPDK driver reports
>         back to application as device current speed is 40G, without really
>         knowing the current speed.
>         "
> 
> 
>     Yes, that is. Should then I do anything else or the patch is right
>     for you now?

So, this patch is correct.

But for the previous patch "net/nfp: report link speed using hardware
info", it would be nice to add above information into source as comment
and into commit log.
If you can, would you mind sending a new version of that patch?

Thanks,
ferruh

>      
<...>