From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA5894332E; Tue, 14 Nov 2023 20:14:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 972CA402D4; Tue, 14 Nov 2023 20:14:46 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2080.outbound.protection.outlook.com [40.107.223.80]) by mails.dpdk.org (Postfix) with ESMTP id 9CC1C402B3; Tue, 14 Nov 2023 20:14:45 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CQLfJ2W9KTqOWA8tR46XU6QFkrlrt8WbJvpbE7V+hQmPrxg6XrE0bQan9o55VH8g70CXN7UK1U0Qtc8Q1i2P+H/ITwsrGk0NUfvLIbCsOt773wiveezVIIwch+Hcyo2Ye/0PI9unn+VQiZkcZ/+t4D5sBZa8YwIyvAM/RvU+mJh7EenKr9RRyzIU5WkESVdkXmJ/9UtzQppYjA6RWEbPqB5NVKh1W4TNsLXY2M1qQr3iVaPMmvddI4NG1drNeDid+kOqzf+fEB2P9LGn8DPiz4GC1cUKnDmqS6WbwbUJ4SkOYajUTKRI4WDLyRkWjIu+LBNKtDdKH/fkefG0rOuH0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yaKRzejEQBQnDko2NH10jY/fh4ZAlrrussjxlS+G6mg=; b=aLleEOf/HWM2nDVQmA/QGh1cMQfOqjvk8ZeQjClG4EmFsZ4VfenO+sZYdIc7n2oCaMzwyTmXSeYpjeTqWcESXAT8L8jHMY2PqsMQbyOaRS5uNcxIjdUr7h0JSC9jtTX0EqDTQtFb3dHh+VgEvDEcxPvLqjyBdajTEqQoxrfloElX+UTubTdGUj86yHSUJ+9qle5zPnr4nCfLPlm+CH5uysUCFQCXYFYDloLfg3IEh9WG509mcq/RANsUkgFWw953Wfs/Wdvd6jpdZBlGpW4pc9bevNtV9Hi0xzgzFntAwwsJe3XrJZ0Do5r6X0dYjej1DjBStOLY4p2osOQKrYPAcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yaKRzejEQBQnDko2NH10jY/fh4ZAlrrussjxlS+G6mg=; b=Sd4/zJYzb2KscXjo7/kfUlIp1zjJAt0bf8h3Q5/zaLIgTrQ4QXiUg5r/0+6l+GBEDpS6fw94oTtmWDZCyItb5HmATrWkhTHtmo+FR1DKJ9sNpIxLcX1byxs2246crHMr8vW4Vamdh/0ap+2rsv6KgMaL1dy7XC2yDXoTsCsBbGRsG2Rv8HSyfsZtKKRVohHHSMU1vgRZt+3wNsrpLpShn+lS60XdK+tT6kMvttzUzq1V0Le5VLZGAsUfpF/gOBxm3r6w+WIAQDb0fVw7omiLf2k8kwlxSzR123FZOnGdIVrxU2dZeSQerQgyCqisC1VvRcGSctABL5sfqRokSc7Q5w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from IA1PR12MB6332.namprd12.prod.outlook.com (2603:10b6:208:3e2::13) by SA1PR12MB6775.namprd12.prod.outlook.com (2603:10b6:806:25a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.31; Tue, 14 Nov 2023 19:14:42 +0000 Received: from IA1PR12MB6332.namprd12.prod.outlook.com ([fe80::43ed:468d:3105:4071]) by IA1PR12MB6332.namprd12.prod.outlook.com ([fe80::43ed:468d:3105:4071%4]) with mapi id 15.20.6977.029; Tue, 14 Nov 2023 19:14:42 +0000 Date: Tue, 14 Nov 2023 21:14:38 +0200 (IST) From: "Etelson, Gregory" To: Tyler Retzlaff cc: "Etelson, Gregory" , dev@dpdk.org, mkashani@nvidia.com, thomas@monjalon.net, stable@dpdk.org, Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam Subject: Re: [PATCH] eal/windows: fix memory management macros usage In-Reply-To: <20231114182212.GA3681@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Message-ID: References: <20231114170529.176665-1-getelson@nvidia.com> <20231114174637.GC23774@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20231114182212.GA3681@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Content-Type: text/plain; charset=US-ASCII; format=flowed X-ClientProxiedBy: LO4P302CA0025.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c1::13) To IA1PR12MB6332.namprd12.prod.outlook.com (2603:10b6:208:3e2::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR12MB6332:EE_|SA1PR12MB6775:EE_ X-MS-Office365-Filtering-Correlation-Id: b0ca37ac-6ed8-48db-fc51-08dbe545f4a9 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7nC04PQNgtx4Rd7CzSXpki3iX2y8IZTwd0gf38xx0EbHx8Rd5WPK7wNblgysoV388DOQQS4AxhMvs6ctIQvCstTEJ2wt6Po/uELBXstwGG+pfx2jzjx+BJtBve0XGzyrYUyJ6jyq1rjpnUZhQqQTqhILyIQjBdJGAz8yhm/14B5LTfdECyr3YJSkk7HN6vsb9Ahex6lx6ipve6DGDx2bT0wMnPwA/+KV8P4wiT0iRfrauTgryc5/lx2CKMDHPyEVS8PHBISbgcPJHhjI3WMxUzAIoeo1ixg/U7IWkdRyURQQjbvd9ANk5ACTU0wayIWS1zpyGfjbZm6HvnxpvRc1rNlXRkh9O0GIzjoOCQybBIzeommQoJLsxeJhUt2wue3vHC4k92LHxUuNqkI7nIfODwFnvVQwSTQd3LRPO+1EwVQ+rPEXWOoTJzEBKXzmovhokpttqn7nLYj44oK0x+7byoiZB0zfQ3CUccsQvVMIzeDeUAkZBdriwzvSr5agaINdXlotrghpJUvRmmekAFHTWSDTfN3ZIyK3IJKfwgUbIjR0NTxU14Wt+RGESycjzGJxH1NLJLmZZgF8KO2OKszOqfAN+eqVY1nTlTz7J1g2GdVsFYisYEPf3Aq53cAC4uTt X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:IA1PR12MB6332.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(346002)(39860400002)(376002)(136003)(366004)(230922051799003)(451199024)(1800799009)(186009)(64100799003)(6506007)(6512007)(36756003)(2906002)(38100700002)(83380400001)(41300700001)(86362001)(31696002)(2616005)(5660300002)(478600001)(6916009)(316002)(66476007)(54906003)(66556008)(66946007)(6486002)(31686004)(6666004)(8676002)(4326008)(8936002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cWHHuhm5F6F8e4yOSr8zF9sWDQBqO3Vqx94TO/sab64W3p/hQNUCgrJutXeL?= =?us-ascii?Q?26FJqP/4zzH4EOIdnkzjhOBJK9P9icxEpIJpmJPWH6bDk3dMhd5QhJX1dkdN?= =?us-ascii?Q?nFxtw6h32l0Ma+Kl7UZi9EHMhXVorZgiscnbPwCQqaPkSIPCtVvJMuJ+j0Y4?= =?us-ascii?Q?SWpxHaypdZM2tX6IOTBlw1KcaTrJ/eD+NEJPq2lb4ucpMD5dD2LnBnr+yQ6c?= =?us-ascii?Q?xX8pIKbjw8pIyYGglc9jZ/E0NPYIaKmX2iBNAyGCMuaEEeb+AChF7x0G4/Jv?= =?us-ascii?Q?tr/RX4ed3fn7BM+wVCSkiYqTSy6Z2SjoB9ZhBqZAOPWlfqUh73uzfyt5KA8f?= =?us-ascii?Q?RYslei4hTCHd5t+yvdA4jhyWOqPuKBqi1qLQ7Yk62M0rVb2ITwJ4I2FBuQKl?= =?us-ascii?Q?rlcvL/KchCN2ho8IGe6k1CeJrSHKsnu7J4h+HcArQT9X9yYD58926AM4aIkj?= =?us-ascii?Q?Cn5mHc4ocDMt5aokDRv2N4hWYqDDo5YmbRfbJWCXFSsfsRfuYzoAmu7gOEKv?= =?us-ascii?Q?/lkkAJUWVUZTH8mHcmhioKDmaoX2fM0omckkPv+5Far9v2yx0qbVMEkkWBq+?= =?us-ascii?Q?R9PCl3+LOsfDwX3cophFnCeMhkelvQdzUyALD7siYjb0BIjoy2lx0tHW76RP?= =?us-ascii?Q?EDSJI6O9R6NeCmMZsnWGVjk4n8ZajPKMTDsuy09J7ANbDyVtnWXVrhWZj109?= =?us-ascii?Q?SAj11iBjmznUcFgDH+XXvazcnIQSN2FC9DQ7BaxVxONdIV1q04ZhSKqv5pIt?= =?us-ascii?Q?4yJvVzcrr4XzYy1KopAW8hITeY4T7r86/xGinRWOub1V/AYgN5bHi7ihElT4?= =?us-ascii?Q?wy5OEpZCLQVedQyJEn5od9XnQlrBZFLbItNslD6N/8Rzhej+8+GjDSGxvQVX?= =?us-ascii?Q?+GAAeZ3SHYd9SvDjXuzyv9rtCZb+t3L/QGCXQTNTURl8KtDe4j+vz794Tc0G?= =?us-ascii?Q?Y3Sa2zAwqkQgCNCQ261nPqVngJ6PvpBubEpoonGmMKBYXV41I+x2QLPmlC1k?= =?us-ascii?Q?RzDcoV690nGf0N2zAJAgo6RfNa2ZXiuEzSwhvdJW2/XVYvK6i5+ugaK87T1g?= =?us-ascii?Q?aHahIadNjksG3oiPhm309VDAEI1JOD2as4XVBiQQFuxrAFLx9wIHM1QaxoSc?= =?us-ascii?Q?p774R79Qwo3EWfwSVW/8Np2Suhfj/rNoKmD4+i7/xexYz32SAGtSBh351iQ4?= =?us-ascii?Q?6FyyovDNKz1nYryMDnICKVMmKXQ14OMSM6NmKFgDUtTNNeyExiloQXOgndWK?= =?us-ascii?Q?75nOUHE9Q9OOH1NygLZdubWDrHYf3kJbColPNWpLyF1Gq3uGJoa5WUWk9pFt?= =?us-ascii?Q?jMzq2XPxzEP9S9Xmk0pSWEaMTD99MftOd8KsU+hcEK630T+NeS/VZDJ1GDBl?= =?us-ascii?Q?y8NbBOwjE2Tnqxa6RAgXgPYU4OOMBsmtc+KTch5OxTcFbjJhNW1RHNay1X9w?= =?us-ascii?Q?7ACcEuCmhiPGYV8xO4oSTPANB64iuokFpmsv1doWoDpFc3x6TIxLP91skFHq?= =?us-ascii?Q?7ntRcw53KMnkb8B+0PAaJE7dC0GeQUEVPjDjLLUQwlfBlmo5jytXH+MilP9k?= =?us-ascii?Q?PWB4hkNe6g++vjY1N7iHZ2zBC1AngZ1rCfTgCLJVZvUxOm2Fq6AOdXaiMrtO?= =?us-ascii?Q?3NlUxR6gKkhvSV+JoHfmzhjhQ4rMLqmUPwyWN13E+iOj?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0ca37ac-6ed8-48db-fc51-08dbe545f4a9 X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6332.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2023 19:14:42.4603 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: osIr86PcucJ798+d9v36RdmjXepMLLJn5eat4eCayWDfk7MRc4GmnAvEimTT+SO+I2eTQQMd/LEBZWm0PEI4cw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6775 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Tyler, >>> >>> since we are duplicating something that comes from something else that >>> has been duplicated out of windows WDK here it might be a reasonable >>> safety check to verify that our duplicated values match our >>> expectations? >> >> MEM_COALESCE_PLACEHOLDERS, MEM_PRESERVE_PLACEHOLDER, >> MEM_REPLACE_PLACEHOLDER and MEM_RESERVE_PLACEHOLDER >> are defined in Win32 API. >> >> DPDK has no expectations about these values. DPDK needs them as >> parameters to the VirtualX function calls. >> It looks like the macros were added to EAL because they were missing >> in mingw. >> >> Once compiler environment was fixed, the proper order was restored. > > yes, there is a lag between when names appear in the actual WDK and when > mingw takes a the snapshot of the headers. so long as the copy they take > is only from released WDK versions that align with an OS we shouldn't > expect the values to change but if the duplicated names in dpdk were > based upon an insider (preview version of SDK) value that later got changed > there could be a misalignment. unlikely but possible. > DPDK matrix works with official OS compiler versions. Such compilers will not provide bad API. As for non-official compilers or releases, they come without any warranty. Regards, Gregory