From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id BFEA8A00E6 for ; Thu, 16 May 2019 13:35:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5D2515F21; Thu, 16 May 2019 13:35:45 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 208C25F20 for ; Thu, 16 May 2019 13:35:43 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4FC98305B416; Thu, 16 May 2019 11:35:43 +0000 (UTC) Received: from [10.36.112.43] (ovpn-112-43.ams2.redhat.com [10.36.112.43]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6D4116031D; Thu, 16 May 2019 11:35:42 +0000 (UTC) To: Haiyue Wang , qi.z.zhang@intel.com, dev@dpdk.org References: <1557839982-27012-1-git-send-email-haiyue.wang@intel.com> From: Maxime Coquelin Message-ID: Date: Thu, 16 May 2019 13:35:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1557839982-27012-1-git-send-email-haiyue.wang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Thu, 16 May 2019 11:35:43 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v1] net/ice: change RSS RETA size to meet with ETH_RSS_RETA_SIZE_x X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/14/19 3:19 PM, Haiyue Wang wrote: > Since ice can support 128, 512, 2K three RSS RETA size, and if set 2K > by default, this will make it not compatible with ETH_RSS_RETA_SIZE_x > value definition, limit it to 512 if the cap.rss_table_size exceeds the > max value 512. It looks like a fix, so "Fixes:" tag would we welcome. > Signed-off-by: Haiyue Wang > --- > drivers/net/ice/ice_ethdev.c | 22 ++++++++++++++++------ > 1 file changed, 16 insertions(+), 6 deletions(-) >