From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 7AF4D5A6A for ; Thu, 1 Nov 2018 17:05:36 +0100 (CET) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20181101160536euoutp01b005d5c13a289188d390691d1a1e22bc~jC61IHP440487204872euoutp01M for ; Thu, 1 Nov 2018 16:05:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20181101160536euoutp01b005d5c13a289188d390691d1a1e22bc~jC61IHP440487204872euoutp01M DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1541088336; bh=qSOuIKqbn/jwPnJ9PylC7iPyRkNqm7gz4oYIaRkh7+Y=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=tr97Lagzdd2ePiFrapKlIcx5wzsS5sNctUsydI5JWWFFVGY1xkcVKYAM2Pxj4DlxC aN6f2nRrG+3VSaOPbblaQakahvZLyaKwI19N+MzGRDcfbjx7JQf8VbI7Ja10CWEdMo gbuhi/xxkTtAw24yVM18LBVp0V+u28sbgI0iHbpE= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20181101160535eucas1p1d3877d2ddf42de7a8209dda4aff81ac9~jC60qpGa01856818568eucas1p1O; Thu, 1 Nov 2018 16:05:35 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id A6.EC.04806.F442BDB5; Thu, 1 Nov 2018 16:05:35 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20181101160534eucas1p2781a03b90b9766443ac643fe0381c107~jC6zu2CrV2168821688eucas1p28; Thu, 1 Nov 2018 16:05:34 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20181101160534eusmtrp228970be11bd00db407dd780b6866df28~jC6zbSXaM1803218032eusmtrp2r; Thu, 1 Nov 2018 16:05:34 +0000 (GMT) X-AuditID: cbfec7f5-367ff700000012c6-6c-5bdb244fd531 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 38.BA.04128.E442BDB5; Thu, 1 Nov 2018 16:05:34 +0000 (GMT) Received: from [106.109.129.180] (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20181101160533eusmtip177d7d95623ed3a8105cc9b80d444cf14~jC6yxwNjq0760307603eusmtip1S; Thu, 1 Nov 2018 16:05:33 +0000 (GMT) To: "Zhang, Qi Z" , "dev@dpdk.org" Cc: "Lu, Wenzhuo" , "Ananyev, Konstantin" , Laurent Hardy , Wei Dai , "stable@dpdk.org" , Thomas Monjalon , "Yigit, Ferruh" From: Ilya Maximets Message-ID: Date: Thu, 1 Nov 2018 19:05:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <039ED4275CED7440929022BC67E70611532DE5F7@SHSMSX103.ccr.corp.intel.com> Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGKsWRmVeSWpSXmKPExsWy7djPc7r+KrejDZ6sVLB492k7k8WdvafZ La60/2S3eP9nEYvF5TPTWSymb+hns/jX8Yfd4sum6WwWB161sFhsPfOX0YHL42L/HUaPXwuW snos3vOSyaNvyyrGAJYoLpuU1JzMstQifbsEroxPD3pZCu5oV6xoOcPewLhOpYuRk0NCwERi +t3f7F2MXBxCAisYJW6tP8sE4XxhlOg8+IANwvnMKHH7znegMg6wlmOnsyHiyxklFpxbzwzh fGSU2HvqEzPIXGEBD4lz+44wgtgiAu4Sz1sbWEGKmAVWMElsnTubFSTBJqAjcWo1RBGvgJ3E ldPTmUBsFgEVia//boINEhWIkOi4v5oNokZQ4uTMJywgNqdAiMTC3jnsIDazgLhE05eVrBC2 vMT2t3PALpIQOMYucfzXfyaIT10k/rZ3sEDYwhKvjm9hh7BlJP7vnA9VUy9xv+UlI0RzB6PE 9EP/oBL2EltenwP7n1lAU2L9Ln2IsKPE67afzJBg4ZO48VYQ4gY+iUnbpkOFeSU62oQgqlUk fh9czgxhS0ncfPeZfQKj0iwkn81C8s0sJN/MQti7gJFlFaN4amlxbnpqsXFearlecWJucWle ul5yfu4mRmBqOv3v+NcdjPv+JB1iFOBgVOLh1ZC6FS3EmlhWXJl7iFGCg1lJhHfyBaAQb0pi ZVVqUX58UWlOavEhRmkOFiVx3mXzNkYLCaQnlqRmp6YWpBbBZJk4OKUaGAV0z7td+qqYGDRf +mbQqXz1l8+2pni7G5ziVNe/NXGque0O460hvxg06hLf7/IqWMeUNvXuS0Ple5ZCEn+b62Il VzH7fdTUvekh4uySxjrlzNzHyufeMmS+lBNa8X6CbcV9/swteeePF3/8l5YyP7/m4LyHMkee /D8UvPrzdp13b5X8C+zOmSmxFGckGmoxFxUnAgBTxS27SQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJIsWRmVeSWpSXmKPExsVy+t/xu7p+KrejDZ78k7R492k7k8WdvafZ La60/2S3eP9nEYvF5TPTWSymb+hns/jX8Yfd4sum6WwWB161sFhsPfOX0YHL42L/HUaPXwuW snos3vOSyaNvyyrGAJYoPZui/NKSVIWM/OISW6VoQwsjPUNLCz0jE0s9Q2PzWCsjUyV9O5uU 1JzMstQifbsEvYxPD3pZCu5oV6xoOcPewLhOpYuRg0NCwETi2OnsLkYuDiGBpYwS1yasZO1i 5ASKS0n8+HUByhaW+HOtiw2i6D2jxPx521lAEsICHhLn9h1hBLFFBNwlnrc2sIIUMQusYpK4 vfoaM0THSSaJjedOgY1iE9CROLUaooNXwE7iyunpTCA2i4CKxNd/N5lBbFGBCImzL9dB1QhK nJz5BGwbp0CIxMLeOewgNrOAusSfeZeYIWxxiaYvEGczC8hLbH87h3kCo9AsJO2zkLTMQtIy C0nLAkaWVYwiqaXFuem5xUZ6xYm5xaV56XrJ+bmbGIHRuO3Yzy07GLveBR9iFOBgVOLhZVC+ HS3EmlhWXJl7iFGCg1lJhHfyhVvRQrwpiZVVqUX58UWlOanFhxhNgZ6byCwlmpwPTBR5JfGG pobmFpaG5sbmxmYWSuK85w0qo4QE0hNLUrNTUwtSi2D6mDg4pRoY9yRuDpu/Qk/hbot46g5l dmWHPwGb0+VunjHyrkyICJNtLd0vvPRIX/3ba6lz5kbO/H+7g9mnPvpr+EynFYelv57d2XLp 05P9G6xtJv6JCbMMlXuQr1xzZp+NbO8+N/FY380JixM/WH1r376i47ReUuHcVZ9Wnwjz6Z89 vXWFcnSQ5NRt8662KbEUZyQaajEXFScCAImgBK7cAgAA X-CMS-MailID: 20181101160534eucas1p2781a03b90b9766443ac643fe0381c107 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20180831123824eucas1p1cd2981c716c4764703e24c3eeb4d33c7 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180831123824eucas1p1cd2981c716c4764703e24c3eeb4d33c7 References: <20180831123824eucas1p1cd2981c716c4764703e24c3eeb4d33c7~P_GOOSRuf0867908679eucas1p1K@eucas1p1.samsung.com> <039ED4275CED7440929022BC67E70611532DE5F7@SHSMSX103.ccr.corp.intel.com> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix busy polling while fiber link update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2018 16:05:36 -0000 On 01.11.2018 18:45, Zhang, Qi Z wrote: > > >> -----Original Message----- >> From: Ilya Maximets [mailto:i.maximets@samsung.com] >> Sent: Tuesday, October 30, 2018 5:21 AM >> To: dev@dpdk.org >> Cc: Lu, Wenzhuo ; Ananyev, Konstantin >> ; Laurent Hardy >> ; Wei Dai ; >> stable@dpdk.org; Zhang, Qi Z ; Thomas Monjalon >> ; Yigit, Ferruh >> Subject: Re: [PATCH] net/ixgbe: fix busy polling while fiber link update >> >> Any more thoughts on that fix? >> Or is there any chance for it to be accepted? > > Would you rebase to dpdk-next-net-intel? Done. > Thanks > Qi > >> >> Best regards, Ilya Maximets. >> >> On 31.08.2018 15:39, Ilya Maximets wrote: >>> If the multispeed fiber link is in DOWN state, ixgbe_setup_link could >>> take around a second of busy polling. This is highly inconvenient for >>> the case where single thread periodically checks the link statuses. >>> For example, OVS main thread periodically updates the link statuses >>> and hangs for a really long time busy waiting on ixgbe_setup_link() >>> for a DOWN fiber ports. For case with 3 down ports it hangs for a 3 >>> seconds and unable to do anything including packet processing. >>> Fix that by shifting that workaround to a separate thread by alarm >>> handler that will try to set up link if it is DOWN. >>> >>> Fixes: c12d22f65b13 ("net/ixgbe: ensure link status is updated") >>> CC: stable@dpdk.org >>> >>> Signed-off-by: Ilya Maximets >>> --- >>> drivers/net/ixgbe/ixgbe_ethdev.c | 43 >>> ++++++++++++++++++++++++-------- >>> 1 file changed, 32 insertions(+), 11 deletions(-) >>> >>> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c >>> b/drivers/net/ixgbe/ixgbe_ethdev.c >>> index 26b192737..a33b9a6e8 100644 >>> --- a/drivers/net/ixgbe/ixgbe_ethdev.c >>> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c >>> @@ -221,6 +221,8 @@ static int ixgbe_dev_interrupt_action(struct >> rte_eth_dev *dev, >>> struct rte_intr_handle *handle); static void >>> ixgbe_dev_interrupt_handler(void *param); static void >>> ixgbe_dev_interrupt_delayed_handler(void *param); >>> +static void ixgbe_dev_setup_link_alarm_handler(void *param); >>> + >>> static int ixgbe_add_rar(struct rte_eth_dev *dev, struct ether_addr >> *mac_addr, >>> uint32_t index, uint32_t pool); >>> static void ixgbe_remove_rar(struct rte_eth_dev *dev, uint32_t >>> index); @@ -2791,6 +2793,8 @@ ixgbe_dev_stop(struct rte_eth_dev *dev) >>> >>> PMD_INIT_FUNC_TRACE(); >>> >>> + rte_eal_alarm_cancel(ixgbe_dev_setup_link_alarm_handler, dev); >>> + >>> /* disable interrupts */ >>> ixgbe_disable_intr(hw); >>> >>> @@ -3969,6 +3973,25 @@ ixgbevf_check_link(struct ixgbe_hw *hw, >> ixgbe_link_speed *speed, >>> return ret_val; >>> } >>> >>> +static void >>> +ixgbe_dev_setup_link_alarm_handler(void *param) { >>> + struct rte_eth_dev *dev = (struct rte_eth_dev *)param; >>> + struct ixgbe_hw *hw = >> IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private); >>> + struct ixgbe_interrupt *intr = >>> + IXGBE_DEV_PRIVATE_TO_INTR(dev->data->dev_private); >>> + u32 speed; >>> + bool autoneg = false; >>> + >>> + speed = hw->phy.autoneg_advertised; >>> + if (!speed) >>> + ixgbe_get_link_capabilities(hw, &speed, &autoneg); >>> + >>> + ixgbe_setup_link(hw, speed, true); >>> + >>> + intr->flags &= ~IXGBE_FLAG_NEED_LINK_CONFIG; } >>> + >>> /* return 0 means link status changed, -1 means not changed */ int >>> ixgbe_dev_link_update_share(struct rte_eth_dev *dev, @@ -3981,9 >>> +4004,7 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, >>> IXGBE_DEV_PRIVATE_TO_INTR(dev->data->dev_private); >>> int link_up; >>> int diag; >>> - u32 speed = 0; >>> int wait = 1; >>> - bool autoneg = false; >>> >>> memset(&link, 0, sizeof(link)); >>> link.link_status = ETH_LINK_DOWN; >>> @@ -3993,13 +4014,8 @@ ixgbe_dev_link_update_share(struct >> rte_eth_dev >>> *dev, >>> >>> hw->mac.get_link_status = true; >>> >>> - if ((intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) && >>> - ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) { >>> - speed = hw->phy.autoneg_advertised; >>> - if (!speed) >>> - ixgbe_get_link_capabilities(hw, &speed, &autoneg); >>> - ixgbe_setup_link(hw, speed, true); >>> - } >>> + if (intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) >>> + return rte_eth_linkstatus_set(dev, &link); >>> >>> /* check if it needs to wait to complete, if lsc interrupt is enabled */ >>> if (wait_to_complete == 0 || dev->data->dev_conf.intr_conf.lsc != 0) >>> @@ -4017,11 +4033,14 @@ ixgbe_dev_link_update_share(struct >> rte_eth_dev *dev, >>> } >>> >>> if (link_up == 0) { >>> - intr->flags |= IXGBE_FLAG_NEED_LINK_CONFIG; >>> + if (ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) { >>> + intr->flags |= IXGBE_FLAG_NEED_LINK_CONFIG; >>> + rte_eal_alarm_set(10, >>> + ixgbe_dev_setup_link_alarm_handler, dev); >>> + } >>> return rte_eth_linkstatus_set(dev, &link); >>> } >>> >>> - intr->flags &= ~IXGBE_FLAG_NEED_LINK_CONFIG; >>> link.link_status = ETH_LINK_UP; >>> link.link_duplex = ETH_LINK_FULL_DUPLEX; >>> >>> @@ -5128,6 +5147,8 @@ ixgbevf_dev_stop(struct rte_eth_dev *dev) >>> >>> PMD_INIT_FUNC_TRACE(); >>> >>> + rte_eal_alarm_cancel(ixgbe_dev_setup_link_alarm_handler, dev); >>> + >>> ixgbevf_intr_disable(dev); >>> >>> hw->adapter_stopped = 1; >>>