From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 515775B3E for ; Wed, 3 Apr 2019 00:57:47 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Apr 2019 15:57:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,302,1549958400"; d="scan'208";a="333205676" Received: from anandraw-mobl.amr.corp.intel.com (HELO [10.121.163.141]) ([10.121.163.141]) by fmsmga006.fm.intel.com with ESMTP; 02 Apr 2019 15:57:47 -0700 To: Thomas Monjalon Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com, david.marchand@redhat.com References: <20190306041634.12976-1-anand.rawat@intel.com> <20190402035458.14664-1-anand.rawat@intel.com> <20190402035458.14664-9-anand.rawat@intel.com> <3599974.brf36yD2AO@xps> From: Anand Rawat Message-ID: Date: Tue, 2 Apr 2019 15:57:47 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <3599974.brf36yD2AO@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8 08/10] eal: add minimum viable code for eal on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 22:57:48 -0000 On 4/2/2019 3:39 PM, Thomas Monjalon wrote: > I think the change below is bad because it is exposing an internal > function in a header file which may be included by apps. > I know you are still looking for pthread integration solutions, > so we can discuss how to fix it later. > > Note that there is already an EAL function to create normal threads: > rte_ctrl_thread_create() > You may want a similar function for dataplane threads perhaps. > > Yes, we can work on removing eal_thread_create and substituting it with rte_ctrl_thread_create. We have been able to macro substitute quite a lot of pthread lib functionality with Microsoft libc. I can start looking into porting those functionalities for rte_ctrl_thread_create() on Windows. -- Anand Rawat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 75FBFA0679 for ; Wed, 3 Apr 2019 00:57:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D15E95F11; Wed, 3 Apr 2019 00:57:49 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 515775B3E for ; Wed, 3 Apr 2019 00:57:47 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Apr 2019 15:57:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,302,1549958400"; d="scan'208";a="333205676" Received: from anandraw-mobl.amr.corp.intel.com (HELO [10.121.163.141]) ([10.121.163.141]) by fmsmga006.fm.intel.com with ESMTP; 02 Apr 2019 15:57:47 -0700 To: Thomas Monjalon Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com, david.marchand@redhat.com References: <20190306041634.12976-1-anand.rawat@intel.com> <20190402035458.14664-1-anand.rawat@intel.com> <20190402035458.14664-9-anand.rawat@intel.com> <3599974.brf36yD2AO@xps> From: Anand Rawat Message-ID: Date: Tue, 2 Apr 2019 15:57:47 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <3599974.brf36yD2AO@xps> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8 08/10] eal: add minimum viable code for eal on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402225747.03is9QT1w7yhOxjyprQxWP3fWR02dfxCgQjm-1hCajo@z> On 4/2/2019 3:39 PM, Thomas Monjalon wrote: > I think the change below is bad because it is exposing an internal > function in a header file which may be included by apps. > I know you are still looking for pthread integration solutions, > so we can discuss how to fix it later. > > Note that there is already an EAL function to create normal threads: > rte_ctrl_thread_create() > You may want a similar function for dataplane threads perhaps. > > Yes, we can work on removing eal_thread_create and substituting it with rte_ctrl_thread_create. We have been able to macro substitute quite a lot of pthread lib functionality with Microsoft libc. I can start looking into porting those functionalities for rte_ctrl_thread_create() on Windows. -- Anand Rawat