From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 2FA1D1BB78; Wed, 11 Apr 2018 17:02:15 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BCCF5401CC41; Wed, 11 Apr 2018 15:02:14 +0000 (UTC) Received: from [10.36.112.36] (ovpn-112-36.ams2.redhat.com [10.36.112.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3A14A215CDAF; Wed, 11 Apr 2018 15:02:13 +0000 (UTC) From: Maxime Coquelin To: Chas Williams <3chas3@gmail.com>, dev@dpdk.org Cc: mtetsuyah@gmail.com, yliu@fridaylinux.org, Robert Shearman , stable@dpdk.org, Chas Williams References: <20180329160507.25081-1-3chas3@gmail.com> <6ec8aef7-4eac-811b-b520-47ca50206665@redhat.com> Message-ID: Date: Wed, 11 Apr 2018 17:02:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <6ec8aef7-4eac-811b-b520-47ca50206665@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 11 Apr 2018 15:02:14 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 11 Apr 2018 15:02:14 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH 1/2] net/vhost: set the vq consistently X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Apr 2018 15:02:16 -0000 On 04/11/2018 04:46 PM, Maxime Coquelin wrote: > > > On 03/29/2018 06:05 PM, Chas Williams wrote: >> From: Robert Shearman >> >> The vid and port of the vq were only set on queues created during initial >> device setup. >> >> Fixes: ee584e9710b9 ("vhost: add driver on top of the library") >> Cc: stable@dpdk.org >> >> Signed-off-by: Robert Shearman >> Signed-off-by: Chas Williams >> --- >>   drivers/net/vhost/rte_eth_vhost.c | 15 +++++++++++++++ >>   1 file changed, 15 insertions(+) >> > > Reviewed-by: Maxime Coquelin It does not apply because a patch from Junjie seems to address the same problem: net/vhost: fix crash when creating vdev dynamically Can you check dpdk-next-virtio/master and confirm this patch is no more required? Thanks, Maxime