DPDK patches and discussions
 help / color / mirror / Atom feed
From: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] app/test: allow building with bonding net driver disabled
Date: Mon, 4 May 2020 21:26:59 +0200
Message-ID: <d2b197f8-2eaf-53b3-41f2-ec378af1d88a@partner.samsung.com> (raw)
In-Reply-To: <20200501150549.6959-1-bruce.richardson@intel.com>

W dniu 01.05.2020 o 17:05, Bruce Richardson pisze:
> The autotest application build was partially enabled for building with
> the net/bond driver disabled, but a number of items were missed, leading
> to build errors when the driver was disabled, e.g. by simply doing
> "-Ddisable_drivers=net/*" when calling meson.
>
>    ../app/test/test_link_bonding.c:25:10: fatal error: rte_eth_bond.h: \
> 	No such file or directory
>
> With this fix in place, it's possible to build DPDK with meson with all
> non-bus, non-mempool drivers disabled i.e. using meson option
>
> -Ddisable_drivers=baseband/*,compress/*,crypto/*,event/*,net/*,raw/*,vdpa/*
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>   app/test/meson.build | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/app/test/meson.build b/app/test/meson.build
> index fc60acbe7..03dd6c3de 100644
> --- a/app/test/meson.build
> +++ b/app/test/meson.build
> @@ -63,8 +63,6 @@ test_sources = files('commands.c',
>   	'test_ipsec_sad.c',
>   	'test_kni.c',
>   	'test_kvargs.c',
> -	'test_link_bonding.c',
> -	'test_link_bonding_rssconf.c',
>   	'test_logs.c',
>   	'test_lpm.c',
>   	'test_lpm6.c',
> @@ -136,6 +134,8 @@ test_sources = files('commands.c',
>   )
>   
>   test_deps = ['acl',
> +	'bus_pci',
> +	'bus_vdev',
>   	'bitratestats',
>   	'bpf',
>   	'cfgfile',
> @@ -306,8 +306,6 @@ driver_test_names = [
>           'cryptodev_sw_zuc_autotest',
>           'eventdev_selftest_octeontx',
>           'eventdev_selftest_sw',
> -        'link_bonding_autotest',
> -        'link_bonding_rssconf_autotest',
>           'rawdev_autotest',
>   ]
>   
> @@ -340,6 +338,8 @@ endif
>   # they are used via a driver-specific API.
>   if dpdk_conf.has('RTE_LIBRTE_BOND_PMD')
>   	test_deps += 'pmd_bond'
> +	test_sources += ['test_link_bonding.c', 'test_link_bonding_rssconf.c']
> +	driver_test_names += ['link_bonding_autotest', 'link_bonding_rssconf_autotest']
>   endif
>   if dpdk_conf.has('RTE_LIBRTE_RING_PMD')
>   	test_deps += 'pmd_ring'
testing conditions:

* confirmed issue without patch and build flag: -Ddisable_drivers=net/* 
fails to build
* with patch applied test app still builds without flags
* with patch applied test app builds with 
-Ddisable_drivers=baseband/*,compress/*,crypto/*,event/*,net/*,raw/*,vdpa/*

Acked-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>

Tested-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>

-- 

Lukasz Wojciechowski
Principal Software Engineer

Samsung R&D Institute Poland
Samsung Electronics
Office +48 22 377 88 25
l.wojciechow@partner.samsung.com


  reply	other threads:[~2020-05-04 19:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200501151113eucas1p11fc2a00e07522e5a29e1918532a1bee8@eucas1p1.samsung.com>
2020-05-01 15:05 ` Bruce Richardson
2020-05-04 19:26   ` Lukasz Wojciechowski [this message]
2020-05-11 19:42     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2b197f8-2eaf-53b3-41f2-ec378af1d88a@partner.samsung.com \
    --to=l.wojciechow@partner.samsung.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git