From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>,
john.mcnamara@intel.com, marko.kovacevic@intel.com
Cc: ferruh.yigit@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] doc: address the offload API changes for virtio guide
Date: Fri, 25 May 2018 09:16:45 +0200 [thread overview]
Message-ID: <d2bb50dc-fe9b-aa2f-3ea9-b8c052962589@redhat.com> (raw)
In-Reply-To: <20180525061748.16184-1-tiwei.bie@intel.com>
On 05/25/2018 08:17 AM, Tiwei Bie wrote:
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
> doc/guides/nics/virtio.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst
> index 8922f9c0b..a42d1bb30 100644
> --- a/doc/guides/nics/virtio.rst
> +++ b/doc/guides/nics/virtio.rst
> @@ -234,7 +234,7 @@ By default, the non-vector callbacks are used:
>
> Vector callbacks will be used when:
>
> -* ``txq_flags`` is set to ``VIRTIO_SIMPLE_FLAGS`` (0xF01), which implies:
> +* ``txmode.offloads`` is set to ``0x0``, which implies:
>
> * Single segment is specified.
>
> @@ -252,7 +252,7 @@ The corresponding callbacks are:
> Example of using the vector version of the virtio poll mode driver in
> ``testpmd``::
>
> - testpmd -l 0-2 -n 4 -- -i --txqflags=0xF01 --rxq=1 --txq=1 --nb-cores=1
> + testpmd -l 0-2 -n 4 -- -i --tx-offloads=0x0 --rxq=1 --txq=1 --nb-cores=1
>
>
> Interrupt mode
>
Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks for handling the change!
Maxime
next prev parent reply other threads:[~2018-05-25 7:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 6:17 Tiwei Bie
2018-05-25 7:16 ` Maxime Coquelin [this message]
2018-05-25 8:41 ` Ferruh Yigit
2018-05-25 8:20 ` Ferruh Yigit
2018-05-25 8:27 ` Tiwei Bie
2018-05-25 8:54 ` Tiwei Bie
2018-05-25 9:09 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2bb50dc-fe9b-aa2f-3ea9-b8c052962589@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=tiwei.bie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).