From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 25B59DE0 for ; Fri, 25 May 2018 09:16:50 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AB6A384221; Fri, 25 May 2018 07:16:48 +0000 (UTC) Received: from [10.36.112.53] (ovpn-112-53.ams2.redhat.com [10.36.112.53]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6CBAD1117659; Fri, 25 May 2018 07:16:47 +0000 (UTC) To: Tiwei Bie , john.mcnamara@intel.com, marko.kovacevic@intel.com Cc: ferruh.yigit@intel.com, dev@dpdk.org References: <20180525061748.16184-1-tiwei.bie@intel.com> From: Maxime Coquelin Message-ID: Date: Fri, 25 May 2018 09:16:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180525061748.16184-1-tiwei.bie@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 25 May 2018 07:16:48 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Fri, 25 May 2018 07:16:48 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH] doc: address the offload API changes for virtio guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 May 2018 07:16:50 -0000 On 05/25/2018 08:17 AM, Tiwei Bie wrote: > Signed-off-by: Tiwei Bie > --- > doc/guides/nics/virtio.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst > index 8922f9c0b..a42d1bb30 100644 > --- a/doc/guides/nics/virtio.rst > +++ b/doc/guides/nics/virtio.rst > @@ -234,7 +234,7 @@ By default, the non-vector callbacks are used: > > Vector callbacks will be used when: > > -* ``txq_flags`` is set to ``VIRTIO_SIMPLE_FLAGS`` (0xF01), which implies: > +* ``txmode.offloads`` is set to ``0x0``, which implies: > > * Single segment is specified. > > @@ -252,7 +252,7 @@ The corresponding callbacks are: > Example of using the vector version of the virtio poll mode driver in > ``testpmd``:: > > - testpmd -l 0-2 -n 4 -- -i --txqflags=0xF01 --rxq=1 --txq=1 --nb-cores=1 > + testpmd -l 0-2 -n 4 -- -i --tx-offloads=0x0 --rxq=1 --txq=1 --nb-cores=1 > > > Interrupt mode > Acked-by: Maxime Coquelin Thanks for handling the change! Maxime