From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 0AAE51B102 for ; Fri, 21 Sep 2018 20:10:36 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Sep 2018 11:10:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,285,1534834800"; d="scan'208";a="71894491" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.39]) ([10.237.221.39]) by fmsmga007.fm.intel.com with ESMTP; 21 Sep 2018 11:10:27 -0700 To: "Mody, Rasesh" , "dev@dpdk.org" Cc: Dept-Eng DPDK Dev References: <1537394318-17682-1-git-send-email-rasesh.mody@cavium.com> <1537394318-17682-2-git-send-email-rasesh.mody@cavium.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: Date: Fri, 21 Sep 2018 19:10:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1537394318-17682-2-git-send-email-rasesh.mody@cavium.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 2/5] net/bnx2x: update link/PHY management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Sep 2018 18:10:37 -0000 On 9/19/2018 10:59 PM, Mody, Rasesh wrote: > This patch has changes to update the link/PHY management (elink) code > to the latest. > > Signed-off-by: Rasesh Mody > --- > drivers/net/bnx2x/bnx2x.h | 3 + > drivers/net/bnx2x/ecore_hsi.h | 20 +- > drivers/net/bnx2x/elink.c | 7951 ++++++++++++++++++++++++++--------------- > drivers/net/bnx2x/elink.h | 234 +- > 4 files changed, 5231 insertions(+), 2977 deletions(-) <...> > > -static uint8_t elink_xgxs_config_init(struct elink_phy *phy, > - struct elink_params *params, > - struct elink_vars *vars) > +static void elink_xgxs_config_init(struct elink_phy *phy, > + struct elink_params *params, > + struct elink_vars *vars) Getting many build error because of these kind of changes. .../drivers/net/bnx2x/elink.c:12555:17: error: cast between incompatible function types from ‘void (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)’ to ‘uint8_t (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)’ {aka ‘unsigned char (*)(struct elink_phy *, struct elink_params *, struct elink_vars *)’} [-Werror=cast-function-type] .config_init = (config_init_t)elink_xgxs_config_init, ^ perhaps "struct elink_phy" also needs to be updated? Overall build fail log is long, I am not sharing here, I guess if you can able to reproduce one, you will be able to reproduce all.