From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f172.google.com (mail-wr0-f172.google.com [209.85.128.172]) by dpdk.org (Postfix) with ESMTP id 23021330D for ; Wed, 3 May 2017 18:39:19 +0200 (CEST) Received: by mail-wr0-f172.google.com with SMTP id l9so113118672wre.1 for ; Wed, 03 May 2017 09:39:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=reply-to:subject:references:to:cc:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=uStYdAih34bFl6LUDUE9Kkq8lyXGdHeU+xmubByZJt0=; b=a5z1URpi8o40Kxjp+FQgamrM2JCcBELyBE/UfffPn6FXDR6CyD3EkyVx8rN3j9Qq1w cSxd4Nm1GLIskbw4t73SP1I3IxMoZpuKIrwx01eT1uUtRTJY2/xN4WQy9YWrvM9mPRWK 9KJlNRhxNvN+5HQXfyLTGupcEfoy3AftSk6M+ubxkFRQ6cmXZ5g+rvWBQcB2cj/LhWjd 9lWqwy2G3Bi58B50ojmBpLb9lETIL704mINuxp+kxprPJs7uPwuvRdz+5DOsIUI4EanA znlYavmvxK89J0loT5GxuZTgUy3r26FRV9B63ElugG+yfcHog2lUnzEovTTUBoYW+DhF LkyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:references:to:cc:from :organization:message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding; bh=uStYdAih34bFl6LUDUE9Kkq8lyXGdHeU+xmubByZJt0=; b=VKNRj8E9aBK3l6nwi8FqtUMXEgm1tcd+2sIu3bSOGPH3tWldqdFSWWxfM1dKEhtFsY iq6ZwVjbb7DFUplsoz4J18B23/UPVYho1kRKWeLoxlxVhhanD7JY25HvC4LS7Pr7xYqF w41qtXh/EeCR4ce8kQ2F3tcvpTMYsySm1CyxIIBtyZHcbNkdfuXT9z4OcchuySWLrBIa XCcRATlp0akItC3B2eXwkjPnEHRxfQjy7IyVfk6U9KlPHfWz2tdccNFiO/q3/oPeKSZy 0lOwFCZuPuHtKvajSgakBcMir/+EoiZzuTnNC/p9UxZC9WylMJHQQIsO8HDIsP55OBPe 6s8Q== X-Gm-Message-State: AN3rC/73hm0wsHGNafuqczFQ9CBCnmwIptRjuoyqpJ0l3DZL15Ahhv0O 72w/YxvIefpOdxOz X-Received: by 10.223.128.80 with SMTP id 74mr17295615wrk.30.1493829559703; Wed, 03 May 2017 09:39:19 -0700 (PDT) Received: from [10.16.0.164] (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id h9sm12604143wrc.28.2017.05.03.09.39.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 May 2017 09:39:18 -0700 (PDT) References: <20170503160016.31375-1-ferruh.yigit@intel.com> To: Ferruh Yigit , Thomas Monjalon Cc: dev@dpdk.org From: Nicolas Dichtel Organization: 6WIND Message-ID: Date: Wed, 3 May 2017 18:39:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170503160016.31375-1-ferruh.yigit@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] kni: fix ethtool build with kernel 4.11 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: nicolas.dichtel@6wind.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 May 2017 16:39:20 -0000 Le 03/05/2017 à 18:00, Ferruh Yigit a écrit : > build error: > .../build/build/lib/librte_eal/linuxapp/kni/igb_main.c:1034:10: > error: implicit declaration of function ‘pci_enable_msix’ > [-Werror=implicit-function-declaration] > err = pci_enable_msix(pdev, > ^~~~~~~~~~~~~~~ > > This build error observed when CONFIG_RTE_KNI_KMOD_ETHTOOL config option > enabled. > > Following Linux commit removes the pci_enable_msix() > Linux: 4244de1c64de ("PCI: remove pci_enable_msix") > > Switch to pci_enable_msix_range() for kernel > 4.8 since current Linux > igb driver uses this function. When looking at the kernel patches, it seems that the way to go is to use pci_alloc_irq_vectors(), but it needs a bit more work. Exemple : https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=da6f4cf58e40 Regards, Nicolas