From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 044513977 for ; Mon, 17 Jul 2017 18:05:02 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jul 2017 09:05:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,375,1496127600"; d="scan'208";a="126086447" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.249.74.32]) ([10.249.74.32]) by orsmga005.jf.intel.com with ESMTP; 17 Jul 2017 09:04:59 -0700 To: =?UTF-8?Q?Ga=c3=abtan_Rivet?= Cc: dev@dpdk.org References: <20170717155226.GQ11154@bidouze.vm.6wind.com> From: Ferruh Yigit Message-ID: Date: Mon, 17 Jul 2017 17:04:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170717155226.GQ11154@bidouze.vm.6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v10 05/11] net/failsafe: add flexible device definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jul 2017 16:05:03 -0000 On 7/17/2017 4:52 PM, Gaëtan Rivet wrote: > Hi Ferruh, > > (Thanks for the review by the way, I will answer the other more lengthy > emails in due time) > > On Mon, Jul 17, 2017 at 04:45:59PM +0100, Ferruh Yigit wrote: >> On 7/15/2017 6:57 PM, Gaetan Rivet wrote: >>> Add the "exec" device type. >>> The parameters given to this type of device will be executed in a shell. >>> The output of this command is then used as a definition for a device. >>> >>> That command can be re-interpreted if the related device is not >>> plugged-in. It allows for a device definition to react to system >>> changes (e.g. changing PCI bus for a given device). >>> >>> Signed-off-by: Gaetan Rivet >>> Acked-by: Olga Shern >>> --- >>> doc/guides/nics/fail_safe.rst | 20 +++++++ >>> drivers/net/failsafe/failsafe_args.c | 95 +++++++++++++++++++++++++++++++++ >>> drivers/net/failsafe/failsafe_ether.c | 7 +++ >>> drivers/net/failsafe/failsafe_private.h | 4 ++ >>> 4 files changed, 126 insertions(+) >>> >>> diff --git a/doc/guides/nics/fail_safe.rst b/doc/guides/nics/fail_safe.rst >>> index 5ec3031..be73d7e 100644 >>> --- a/doc/guides/nics/fail_safe.rst >>> +++ b/doc/guides/nics/fail_safe.rst >>> @@ -87,6 +87,19 @@ Fail-safe command line parameters >>> additional sub-device parameters if need be. They will be passed on to the >>> sub-device. >>> >>> +- **exec()** parameter >>> + >>> + This parameter allows the user to provide a command to the fail-safe PMD to >>> + execute and define a sub-device. >>> + It is done within a regular shell context. >>> + The first line of its output is read by the fail-safe PMD and otherwise >>> + interpreted as if passed by the regular **dev** parameter. >>> + Any other line is discarded. >>> + If the command fail or output an incorrect string, the sub-device is not >>> + initialized. >>> + All commas within the ``shell command`` are replaced by spaces before >>> + executing the command. This helps using scripts to specify devices. >>> + >>> - **mac** parameter [MAC address] >>> >>> This parameter allows the user to set a default MAC address to the fail-safe >>> @@ -135,6 +148,13 @@ This section shows some example of using **testpmd** with a fail-safe PMD. >>> -w 'net_failsafe0,mac=de:ad:be:ef:01:02,dev(84:00.0),dev(net_ring0)' >>> -w 81:00.0 -- -i >>> >>> +#. Start testpmd using a flexible device definition >>> + >>> + .. code-block:: console >>> + >>> + $RTE_TARGET/build/app/testpmd -c 0xff -n 4 --no-pci \ >>> + --vdev='net_failsafe0,exec(echo 84:00.0)' -- -i >> >> Hi Gaetan, >> >> What is the usecase for this feature. >> >> How this is different from --vdev='net_failsafe0,dev(`echo 84:00.0`)' ? > > This version would be interpreted once, at the launch of the fail-safe > PMD. > > The exec option will execute the command again each time the fail-safe > tries to probe the sub_device. This means that in a live VM migration > context, the sub_device can change PCI address (for example), and still be > matched by the command using other identifying info (MAC address, > class_id, ...). > > It must be reinterpreted upon plugin of the sub_device, > as the output would change from the time the fail-safe was started. Make sense, thanks for clarification.