From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] memory: fix segfault on rte_mem_virt2memseg() call with invalid addr
Date: Fri, 1 Jun 2018 11:50:12 +0100 [thread overview]
Message-ID: <d2f7c166-a0b3-979f-3cbd-9ccfec428ab4@intel.com> (raw)
In-Reply-To: <1527859375-160704-1-git-send-email-dariuszx.stojaczyk@intel.com>
On 01-Jun-18 2:22 PM, Dariusz Stojaczyk wrote:
> When trying to use it with an address that's not
> managed by DPDK it would segfault due to a missing
> check. The doc says this function returns either
> a pointer or NULL, so let it do so.
>
> Change-Id: Ib292f148914e67054f5d7b664077f19cba7000e4
> Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
> ---
Generally speaking, if the commit is a bugfix, reference to the original
commit that introduces the issue should be part of the commit message.
See DPDK contribution guidelines [1] and "git fixline" [2].
[1] http://dpdk.org/doc/guides/contributing/patches.html
[2] http://dpdk.org/dev
Change-Id: is probably a leftover from Gerrit, this shouldn't be part of
the commit message.
On the substance of the patch itself:
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
next prev parent reply other threads:[~2018-06-01 10:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 13:22 Dariusz Stojaczyk
2018-06-01 10:50 ` Burakov, Anatoly [this message]
2018-06-01 13:44 ` [dpdk-dev] [PATCH v2] " Dariusz Stojaczyk
2018-06-01 14:58 ` Burakov, Anatoly
2018-06-04 5:33 ` [dpdk-dev] [PATCH v3] " Dariusz Stojaczyk
2018-07-12 21:44 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2f7c166-a0b3-979f-3cbd-9ccfec428ab4@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dariuszx.stojaczyk@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).