From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 75F715689 for ; Fri, 1 Jun 2018 12:50:15 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jun 2018 03:50:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,465,1520924400"; d="scan'208";a="60410776" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.101]) ([10.237.220.101]) by fmsmga001.fm.intel.com with ESMTP; 01 Jun 2018 03:50:13 -0700 To: Dariusz Stojaczyk , dev@dpdk.org References: <1527859375-160704-1-git-send-email-dariuszx.stojaczyk@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Fri, 1 Jun 2018 11:50:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1527859375-160704-1-git-send-email-dariuszx.stojaczyk@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] memory: fix segfault on rte_mem_virt2memseg() call with invalid addr X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jun 2018 10:50:15 -0000 On 01-Jun-18 2:22 PM, Dariusz Stojaczyk wrote: > When trying to use it with an address that's not > managed by DPDK it would segfault due to a missing > check. The doc says this function returns either > a pointer or NULL, so let it do so. > > Change-Id: Ib292f148914e67054f5d7b664077f19cba7000e4 > Signed-off-by: Dariusz Stojaczyk > --- Generally speaking, if the commit is a bugfix, reference to the original commit that introduces the issue should be part of the commit message. See DPDK contribution guidelines [1] and "git fixline" [2]. [1] http://dpdk.org/doc/guides/contributing/patches.html [2] http://dpdk.org/dev Change-Id: is probably a leftover from Gerrit, this shouldn't be part of the commit message. On the substance of the patch itself: Acked-by: Anatoly Burakov -- Thanks, Anatoly