From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CF08CA0543;
	Tue,  7 Jun 2022 10:15:27 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id C224C4021D;
	Tue,  7 Jun 2022 10:15:27 +0200 (CEST)
Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])
 by mails.dpdk.org (Postfix) with ESMTP id 482F440156;
 Tue,  7 Jun 2022 10:15:26 +0200 (CEST)
Received: from kwepemi500017.china.huawei.com (unknown [172.30.72.53])
 by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4LHNR45Gznz1KDB7;
 Tue,  7 Jun 2022 16:13:36 +0800 (CST)
Received: from [10.67.103.235] (10.67.103.235) by
 kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.24; Tue, 7 Jun 2022 16:15:23 +0800
Subject: Re: [PATCH v3 4/5] app/testpmd: fix slave device isn't released
To: Ferruh Yigit <ferruh.yigit@xilinx.com>, "Min Hu (Connor)"
 <humin29@huawei.com>, <dev@dpdk.org>
References: <20220324030036.4761-1-humin29@huawei.com>
 <20220503100217.46203-1-humin29@huawei.com>
 <20220503100217.46203-5-humin29@huawei.com>
 <cce7b6bc-a739-6b3f-6587-5b8d7f29f7b3@xilinx.com>
CC: Huisong Li <lihuisong@huawei.com>, <stable@dpdk.org>, Xiaoyun Li
 <xiaoyun.li@intel.com>, Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang
 <yuying.zhang@intel.com>, Bernard Iremonger <bernard.iremonger@intel.com>,
 Pablo de Lara <pablo.de.lara.guarch@intel.com>, Andrew Rybchenko
 <andrew.rybchenko@oktetlabs.ru>, Konstantin Ananyev
 <konstantin.v.ananyev@yandex.ru>
From: Dongdong Liu <liudongdong3@huawei.com>
Message-ID: <d331fd08-3a83-3965-5a5c-d4934ff3f644@huawei.com>
Date: Tue, 7 Jun 2022 16:15:23 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <cce7b6bc-a739-6b3f-6587-5b8d7f29f7b3@xilinx.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.103.235]
X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To
 kwepemi500017.china.huawei.com (7.221.188.110)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hi Ferruh

"[PATCH v4] app/testpmd: fix slave device isn't released" has been sent 
out, help to review.

Thanks,
Dongdong
On 2022/6/2 1:54, Ferruh Yigit wrote:
> On 5/3/2022 11:02 AM, Min Hu (Connor) wrote:
>> From: Huisong Li<lihuisong@huawei.com>
>>
>> Currently, some eth devices are added to bond device, these devices
>> are not
>> released when the quit command is executed in testpmd. This patch adds
>> the
>> release operation for all active slaves under a bond device.
>>
>> Fixes: 0e545d3047fe ("app/testpmd: check stopping port is not in
>> bonding")
>> Cc:stable@dpdk.org
>>
>> Signed-off-by: Huisong Li<lihuisong@huawei.com>
>> Signed-off-by: Min Hu (Connor)<humin29@huawei.com>
>
> Hi Connor,
>
> Can you please do the similar #ifdef grouping done in 3/5 patch?
> .
>