From: Anatoly Burakov <anatoly.burakov@intel.com>
To: dev@dpdk.org
Cc: shahafs@mellanox.com, thomasm@mellanox.com, olgas@mellanox.com,
rasland@mellanox.com
Subject: [dpdk-dev] [PATCH 1/2] malloc: set pad to 0 on free
Date: Wed, 2 May 2018 16:38:15 +0100 [thread overview]
Message-ID: <d364f98742dd9d18e25a2280dadfff08a02d9a2e.1525274971.git.anatoly.burakov@intel.com> (raw)
The pad value is not used unless element is in pad state, but it
will show up in heap dumps and may be confusing.
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
lib/librte_eal/common/malloc_elem.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_eal/common/malloc_elem.c b/lib/librte_eal/common/malloc_elem.c
index af81961..0a86d34 100644
--- a/lib/librte_eal/common/malloc_elem.c
+++ b/lib/librte_eal/common/malloc_elem.c
@@ -445,6 +445,8 @@ malloc_elem_free(struct malloc_elem *elem)
malloc_elem_free_list_insert(elem);
+ elem->pad = 0;
+
/* decrease heap's count of allocated elements */
elem->heap->alloc_count--;
--
2.7.4
next reply other threads:[~2018-05-02 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 15:38 Anatoly Burakov [this message]
2018-05-02 15:38 ` [dpdk-dev] [PATCH 2/2] malloc: avoid padding elements on page deallocation Anatoly Burakov
2018-05-02 16:28 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d364f98742dd9d18e25a2280dadfff08a02d9a2e.1525274971.git.anatoly.burakov@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=olgas@mellanox.com \
--cc=rasland@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=thomasm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).