From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3CE344551D; Fri, 28 Jun 2024 06:07:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E50DD427E5; Fri, 28 Jun 2024 06:07:13 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 341504029B for <dev@dpdk.org>; Fri, 28 Jun 2024 06:07:11 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4W9MKp50HJzdfLk; Fri, 28 Jun 2024 12:05:34 +0800 (CST) Received: from kwepemm600004.china.huawei.com (unknown [7.193.23.242]) by mail.maildlp.com (Postfix) with ESMTPS id 60A2E180087; Fri, 28 Jun 2024 12:07:09 +0800 (CST) Received: from [10.67.121.59] (10.67.121.59) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 28 Jun 2024 12:07:08 +0800 Message-ID: <d3799b6f-503e-7e46-8a73-d2e2d1906ad1@huawei.com> Date: Fri, 28 Jun 2024 12:07:08 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v4 1/2] power: introduce PM QoS API on CPU wide To: Stephen Hemminger <stephen@networkplumber.org> CC: <dev@dpdk.org>, <mb@smartsharesystems.com>, <thomas@monjalon.net>, <ferruh.yigit@amd.com>, <anatoly.burakov@intel.com>, <david.hunt@intel.com>, <sivaprasad.tummala@amd.com>, <david.marchand@redhat.com>, <liuyonglong@huawei.com> References: <20240320105529.5626-1-lihuisong@huawei.com> <20240627060011.17816-1-lihuisong@huawei.com> <20240627060011.17816-2-lihuisong@huawei.com> <20240627080651.57f898c8@hermes.local> From: "lihuisong (C)" <lihuisong@huawei.com> In-Reply-To: <20240627080651.57f898c8@hermes.local> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.59] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600004.china.huawei.com (7.193.23.242) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 在 2024/6/27 23:06, Stephen Hemminger 写道: > On Thu, 27 Jun 2024 14:00:10 +0800 > Huisong Li <lihuisong@huawei.com> wrote: > >> + char buf[BUFSIZ] = {0}; > BUFSIZ is 4K and you probably don't need all of that. I rember the maximum buffer length of sysfs show in Linux is BUFSIZ. Just from the same size, here is ok to receive the data from Linux. But LINE_MAX is also enough to use. > And initializing to 0 here should not be needed. Ack > > Why not: > char buf[LINE_MAX]; Thanks for your suggestion. use it in next version. >> + if (latency == 0) >> + sprintf(buf, "%s", "n/a"); >> + else if (latency == RTE_POWER_QOS_RESUME_LATENCY_NO_CONSTRAINT) >> + sprintf(buf, "%u", 0); >> + else >> + sprintf(buf, "%u", latency); > Use snprintf instead. Ack > .