From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DA3842B2C; Wed, 17 May 2023 16:22:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4616340EE1; Wed, 17 May 2023 16:22:38 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 99D06406B7 for ; Wed, 17 May 2023 16:22:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684333356; x=1715869356; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=J3U1HOW3WHoCAUiHkcBFa0wbdjf1RJAfXUVgqpBqXZk=; b=GmOjwBCA2zcbujCgCUth0ecQaH9z/g3u4B4t69sB0GVEhuY2kB3dF6yS PmE9hZ01uUTaTk3kW+MSirZcn0Kr74TZHqL8QfiBpsSQWY2fQ6MAkbVrM ulnSkupG95R4EizIiQtvsGdHOgCCxamTS1iPk0xZhLgviwOF1QA/YK6Tb GLAJ/npFqKy8UCDU3PQTSxmTwSz/p5+Xw6bNA5UYpPi8uQoNzoPTU+CPB YqJ0DT2pOPTTnzuwptycv7AcHxAAPoyLIagVs3le3nAqqzR+mY9mhlmPy mFGuq6DSXT8ljg5wHYTUM48a3oLf/8hJeC4teV/agynUK52k9R3aZl/ct g==; X-IronPort-AV: E=McAfee;i="6600,9927,10713"; a="331387110" X-IronPort-AV: E=Sophos;i="5.99,282,1677571200"; d="scan'208";a="331387110" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2023 07:22:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10713"; a="813882895" X-IronPort-AV: E=Sophos;i="5.99,282,1677571200"; d="scan'208";a="813882895" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 17 May 2023 07:22:34 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 17 May 2023 07:22:35 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 17 May 2023 07:22:34 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 17 May 2023 07:22:34 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 17 May 2023 07:22:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d7HQEaQjhI5UmhDnGja+9a/xbf2stWTbfzmdhejx4OPip80S6oIjPxFUy/XD36rMD9+EIVze96CF+Eh/pMlyrFW0UWCcqcFMrsLnyb3/TZzAufujymiyuTJ0pHEM2h+zKFIKvx+BbPWOB1J8+Y4a9UI182UfUCP0PiPLmUFo9iJQT2SABFCT8laTf95eZF7pO0N/7PUmjG7aGb/LLPUCJInXjsLVSSOV05VAgJDoGHeaPUggHO1s0rX7ysTvtrhzbH0M+H8X66xtHVSj7CwgGkVo4MRjVFm7Vl2Qgu5H/t8FJJYsUSVBjX73X32DFBsgt/XXocygMD4gqiKY4OP6Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m9x4h26ClYc1w0ogSAZr/WZhlBEJX/Q59OYvtkBZQys=; b=Ei4YmVSKHUZLrj4ZAeP/rYR5NZ99i4qev1mtMrq7AexaojjcP2uGxozSH/Uv6b816kulKC3+L+dqP38SNA+cyXNn4lfU4OYF/W2Zh/SgZjoEiX7ezetkzxNiQI8ssFLE1WlVIUBgW0HMcmy7r5sVe7nOmOTtoM8Oi/ktL9xFBwMH94PIDHF6jISw1m6SMh5UhXok4Z0rwa+Wov4VmNk/Trh2SJESt1ySlSh64o8bVmtOc3qq6NSvVyWGszps4k9jgpDFVE+R4xdj+Aytm/St5JCxE+Cwlw8PndS7PtXZweQh0qN3hJGpvbU9zsKXwtQfZ3zlHiLUj1QBmU1BHhW4jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by CH0PR11MB5491.namprd11.prod.outlook.com (2603:10b6:610:d6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.33; Wed, 17 May 2023 14:22:28 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::49c0:aa4c:e5b4:e718]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::49c0:aa4c:e5b4:e718%5]) with mapi id 15.20.6387.033; Wed, 17 May 2023 14:22:28 +0000 Message-ID: Date: Wed, 17 May 2023 15:22:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.11.0 Subject: Re: [RFC PATCH 3/5] eventdev: support optional dequeue callbacks Content-Language: en-US To: Sivaprasad Tummala , , , CC: References: <20230419095427.563185-1-sivaprasad.tummala@amd.com> <20230419095427.563185-3-sivaprasad.tummala@amd.com> From: "Burakov, Anatoly" In-Reply-To: <20230419095427.563185-3-sivaprasad.tummala@amd.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB9PR01CA0005.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::10) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|CH0PR11MB5491:EE_ X-MS-Office365-Filtering-Correlation-Id: 3d03bacd-9383-4393-8821-08db56e2246c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6aJYILUPpGCLUzJlhpgDxP65zs+UUmAyHhm/8wpq9PmLCD5/icdwTJ5mbodFTP9nXXWAxXQsMhDB9e/r1CluP6XdAcRbld9mV18cq9U1tMSPeEEMk6F3QeiwIDC+jtK6grmvXPyfH0SPXcbgZtqAGgUsNH5mdGQ3vuEaVFo9OykUcG8Se9+brmxLEAIpACs5t7FlHXLuDbhNc42YCNPjmGEcb8uXnmQmYOo80FvWk82uHByUxFr7XUwLCtSJ287LVUGqrVqLK8DVF1SVuIylGoAmulhIWghHkFuXxBuc/CNIa2dOtMY2d645E6istafx5oaXKtMoi1fvzyDxzR9IdvKUVIoJEyh32LmGngDU9rK+21wxVM5qayLj1guoQ5tnqNbtcCJMQ5qOg0SHriq29bmshuyKOdUvrMHaCaSwwaAiGfzpXkmadSI4Yp8/uKsEYqVU1iFfWTXKNdkJ5iIqDYwsRV29W/YeNnqdAjP2wtIUNRiZ5S68S9IZC1b4Wz9Z8I9Jxby7qiyJTO34ipt2OLmkVn2IOIuYS1y/k1SrgBOLHb6Ms/LcTfU4My9kW4/XXcVIL+j2O7+/IkpZZTxT9itx1PDYSdT2BZmzEla2ibm5paBw7SpMydY8MVdDGny4v5Dzf5oXFyz311fEO4fLwg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(366004)(346002)(136003)(396003)(39860400002)(451199021)(41300700001)(6666004)(82960400001)(66556008)(4326008)(66946007)(316002)(66476007)(6636002)(6486002)(8936002)(8676002)(478600001)(31686004)(5660300002)(86362001)(26005)(53546011)(6512007)(31696002)(6506007)(2906002)(186003)(38100700002)(2616005)(36756003)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGYvS1RKK3BLWnVEQ2hSNEFRMEVCTUVBNTJtSmdiTjJwNVpKM3VaSHdsb2Jm?= =?utf-8?B?cStHaGdhQ2Ixb0pjWUxESk5ybzVPM3RxYmNHOUhpVURhdHQ0K3dudU5pTTZm?= =?utf-8?B?SmprV09GSCtUVXcxc0tXZVk0N1l0QVhabTZXR1JIMXZpb3ViOW9CMThneEox?= =?utf-8?B?RFRUSmh5Rm9DSXlkVStEKzNqbnlvTDZqUXZUUXZBOTRTcm5IZkxYaXhEQm5H?= =?utf-8?B?eGVaRUxFcWRLOGM0VUFRQUQwdFBBSkJlY3dNMnJtNXM2VnMvOHRLWmZnRFhp?= =?utf-8?B?aVRqY3JHRnc3a3pFWGJXYTNTazAyUkZzUFAwekxqaWs5bnEwbEVOTjRFNWRs?= =?utf-8?B?Tlc5LzVXOEw1RDdhZk05T3d2ZmpNTTErOXJXTTl6Wkt4UWZJaUNGZnp6K05i?= =?utf-8?B?L3Z0REtkdGNSc0dJejAzZjdtTFVBWDltMElYSHR5OXJnandxWFdEODl3Mkhh?= =?utf-8?B?MU1MNXpOeXovS0R0eXRxOVpGZWl5MENkZElMcyt3d1VXUmY1TzZrOXFxSE1r?= =?utf-8?B?OWlmWjJoUGl4STM1clNaNFNYYk5Nc2dKYnR3WXVhVzhDanc1VmhoemJFbXNs?= =?utf-8?B?Mm9xbHg3Ti9Od0xJajBPWTFOMU4rZVYrUnIvZjE0SHhRWkEvWURJd0kvc3hv?= =?utf-8?B?L25HdXBNUVBnMy9pTFRmOUdaekJaeUlUTFVuYWI5SHZaY09Vd2dUOWJHMlRK?= =?utf-8?B?Z1pYQXM0TUpXTFJ5WHBBclU2enE2RmhDalFhRndrTjB4R2tURnJ6cUFUQlJi?= =?utf-8?B?U01EcEowcGJqSk1tRjhYSnpvNGxjaCtpRmtCdGYwaWU0RkNsU3ArMlBKaUtV?= =?utf-8?B?NjBhOFgwTWdRdFczbFdwdlQ3anQxdU16OXFyUGNsVDhGN0N0TWswU2tSTjNO?= =?utf-8?B?R0RqN1k3QVJUczI5M0xoOW1oQmdCRnRIUU1ucVdBbElQRzhTRm93eHZVZXJm?= =?utf-8?B?VWNGVlJoQjVnYjdLOGh2cnA4K3dIcGcxZjdPWVJCcTNzUUp2MXBZbm1FV2hU?= =?utf-8?B?Q2N3YldnYXJQZmEzQ0JJcmJwUk5YUlBhUWVUWSt0T1d5RzFNcERFcy9lUEdz?= =?utf-8?B?NFVuTExsek1MOGdqdE5kbEV0anBUUEZJOWxRekdjS2tOOUxGcENjKzhpS00v?= =?utf-8?B?cWhWdDV2VlUway9hTnFBUDF1OHVXVGdqL3JvRTVNd2trTFNydFBYbUllS05v?= =?utf-8?B?bU9RbEVDTk5mZlJaSEhXeVptMWFWa3FwK0U2U3VkSEpJb1cxNC9HQk9hNkZl?= =?utf-8?B?ZzlrT0dpTi9oZWRvd08wYU9hU3gvcVNuT2F5QmNwOVN5aFpUTmVvN3hJZ3ds?= =?utf-8?B?SUdWc01xQVhTMjFhYVJ0djZTY2Z1Y1J4T09qL1BxUnl3amM0QStMSTlXV2x4?= =?utf-8?B?LysrM3YvUnFCMFRRWWpra21vUWZZbFE0SjkyRzRsTFdLL3lucFgxZXIrOStQ?= =?utf-8?B?ZkhXVkZaOEdFcFI4bENvSk8zNU93YUltSlphUmZDZnRiY2dHK2ZZZjAweDlH?= =?utf-8?B?N3o1RVo5RStUem9NU3dOd2V6VG5KbTNpbEZ2bEFGbG9jc0NDczNuWkVhMVQy?= =?utf-8?B?REVnUkhRVUQ1NXg0cmtUMWVWL1ZOZVcrM0JxWmNpWitPUlpiRmxXaEQ5WHFn?= =?utf-8?B?S3dlMEpnOUlzNmx4cEY1RGpRZUtFNWpBZExrZG43Mi9TRm1UL0JUbVdVRlNs?= =?utf-8?B?WU52VmpMWlFBMFNsb3YxRGhmNGdqWDU4Tkp3L0E1UjN1OUx4b1U4UlU3UHpY?= =?utf-8?B?ekdHRG42REFuU1h1OGhUSTRCaTBrSEdrQjRsVWlWTTJnU3BnU1RjNk9FbEE5?= =?utf-8?B?RGRqVnNacmw3R2xnZFFwZDBBWlVGTnBEUTVzclJacnAxNzFyd3k1QStFY2Nr?= =?utf-8?B?d29vNDZnYVNPNDMvbFN4ZVdLblg3eldGZElMNmQ4VDlTZExrYXI2bVpMTzFr?= =?utf-8?B?dnR0MUFhc1B6ajNGdzlRdTllQ0dkWW9DQ3hpOVIxZGczanhmNmxJMS9tUHNX?= =?utf-8?B?L1hFdmpSbUZnejNzMTY0SmhKM2JKZUJBdmM4NnZ4VkJ6Vm9nWTV6ZU56SHNp?= =?utf-8?B?NnhVYUJTUDNRa0lBM1A0TExuM1ZwNEgwZWt0bk1JR0pBaHkrRVJia2RrVktj?= =?utf-8?B?Q1R3M3YyMEV5MHFqZVVBUEp3RzFacmd1MnFkTFlHZVptZVVMWXNBeE9aSTBQ?= =?utf-8?B?bFE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3d03bacd-9383-4393-8821-08db56e2246c X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2023 14:22:27.9658 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0nxCjPi/8E7E0SbKXOLLliUTYAUm6qhnpcB/WfrLRuvM9MIlOFV5wzYhQ7uytyr1PwEFlPW1aoGkXAukdCuPUi0DM9yOtqQj0Kc5Ua2nxf8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5491 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/19/2023 10:54 AM, Sivaprasad Tummala wrote: > Add optional support for inline event processing within dequeue call. > For a dequeue callback, events dequeued from the event port were > passed them to a callback function if configured, to allow > additional processing. e.g. unpack batch of packets from each event > on dequeue, before passing back to the application. > > Signed-off-by: Sivaprasad Tummala > --- Hi, > +/** > + * @internal > + * Structure used to hold information about the callbacks to be called for a > + * port on dequeue. > + */ > +struct rte_event_dequeue_callback { > + struct rte_event_dequeue_callback *next; > + union{ > + rte_dequeue_callback_fn dequeue; > + } fn; > + void *param; > +}; ...and... > + > +uint16_t > +rte_event_dequeue_callbacks(uint8_t dev_id, uint8_t port_id, > + struct rte_event *ev, uint16_t nb_events, void *opaque) > +{ > + static uint16_t nb_rx; > + const struct rte_event_dequeue_callback *cb = opaque; > + > + while (cb != NULL) { > + nb_rx = cb->fn.dequeue(dev_id, port_id, ev, > + nb_events, cb->param); > + cb = cb->next; > + } > + return nb_rx; Nitpicking an RFC, but this kind of looks like reimplementation for TAILQ functionality? -- Thanks, Anatoly