From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0F32A052A; Sat, 28 Nov 2020 23:46:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 983B7C902; Sat, 28 Nov 2020 23:46:17 +0100 (CET) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 31EF4C8F4 for ; Sat, 28 Nov 2020 23:46:15 +0100 (CET) Received: by mail-wm1-f65.google.com with SMTP id c198so9629162wmd.0 for ; Sat, 28 Nov 2020 14:46:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mayadata-io.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=46E7ZlflTP69Nz4VejaNlECyxdlaRm3cLvrxCCW5PdY=; b=qmCnnutxtcNwepwEeo4l/jEbXNktLaoK35V3Nl6oI4qWciC/1OVgp3AN27MOYc0av2 Mp+qQogA7U3kVxLh0Crs5nATISAojZaK+Mlqs5Ca+00wzJY8t8oNTstVMpVrjNrFRupK 8Wa6MxrSorXaX1pFjtfTtBvGKv5AD0Kbh5fIa/A774P/iONWd+gHXE/DZNUNQvJClkIm /pfDfK/vETigQXcq6iqxJYHtXfIjX3Yio7fmUAMJ6kKNGt6gb4pStJhc4NTrFQhx1y4P S8mJ1tFc5vFekkyHyNXG00BsEa+fQgzRoo1IlQNKKN4zXlMFDwgowI3E7q2oLJjYXuXa xqZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=46E7ZlflTP69Nz4VejaNlECyxdlaRm3cLvrxCCW5PdY=; b=YtbjVVsLZ1mANwZmmlRsyL8Jw3S70J20QTf9UA1OyETkWY9W4jmUmMc0j8HnBPWHHQ 476SoZKb+m30UgWVuROnBIbN968Aq/MuUoYxl6t1RZ9bSaKKPsa81FxqMX1XYjK/HFmo Ky1c//dgSB7OCGACQkDWxZB96+i4lIwx95Gz4w5eIO+yPXyQUvgpQCgdBmCxel8X3KIg lnY/StjfZGBbkcmLwZrcceg/PLOsBJRZ2p9G3vlB/kzKEHsuGtbNfR0lzJgBk0gXjsGb 3B0P+Ad68DA+Vk0oeY47e7QDZEdiQrPM5j+1TUOokoXuzNSQSLm8XE/oMvcF8okc2y+D UJOQ== X-Gm-Message-State: AOAM533MeAhYZYqhBnHuO5fDH9JsXjTOCxcyw8TMucOc/0q01tqCBIVx Veu2hmYtAINyj4W5hlstzAVeRQ== X-Google-Smtp-Source: ABdhPJwz2VEdQQc6HRyB2w8z9fnSI5m+PRFB8oN/fzfAnCGL8X8a7LGlUQL3QNZUTxsC3UzxhJm7CQ== X-Received: by 2002:a1c:e042:: with SMTP id x63mr16115900wmg.68.1606603573892; Sat, 28 Nov 2020 14:46:13 -0800 (PST) Received: from [192.168.0.58] (cpc98320-croy25-2-0-cust77.19-2.cable.virginm.net. [80.235.134.78]) by smtp.gmail.com with ESMTPSA id q81sm19752355wme.34.2020.11.28.14.46.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Nov 2020 14:46:13 -0800 (PST) From: Nick Connolly X-Google-Original-From: Nick Connolly To: Dmitry Kozlyuk Cc: Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , dev@dpdk.org, David Marchand , stable@dpdk.org References: <20201127120711.15703-1-nick.connolly@mayadata.io> <20201129001132.2a387aab@sovereign> Message-ID: Date: Sat, 28 Nov 2020 22:46:12 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201129001132.2a387aab@sovereign> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH] eal/windows: vfprintf build warning with clang X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Looks good to me! On 28/11/2020 21:11, Dmitry Kozlyuk wrote: > On Fri, 27 Nov 2020 12:07:11 +0000, Nick Connolly wrote: >> [...] >> +#ifdef __clang__ >> +#pragma clang diagnostic push >> +#pragma clang diagnostic ignored "-Wformat-nonliteral" >> +#endif >> [...] > How about a more safe approach? > > diff --git a/lib/librte_eal/windows/eal_lcore.c b/lib/librte_eal/windows/eal_lcore.c > index d5ff721e0..ebcd3474e 100644 > --- a/lib/librte_eal/windows/eal_lcore.c > +++ b/lib/librte_eal/windows/eal_lcore.c > @@ -37,6 +37,7 @@ struct cpu_map { > static struct cpu_map cpu_map = { 0 }; > > /* eal_create_cpu_map() is called before logging is initialized */ > +__rte_format_printf(1, 2) > static void > log_early(const char *format, ...) > {