From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55A54423EF; Mon, 16 Jan 2023 13:07:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EDF0B40DFD; Mon, 16 Jan 2023 13:07:04 +0100 (CET) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id A58AA40A7D for ; Mon, 16 Jan 2023 13:07:03 +0100 (CET) Received: from kwepemm600004.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4NwW1W3qYgz16N7h; Mon, 16 Jan 2023 20:05:19 +0800 (CST) Received: from [10.67.103.231] (10.67.103.231) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 16 Jan 2023 20:07:00 +0800 Message-ID: Date: Mon, 16 Jan 2023 20:06:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH V8 0/8] telemetry: fix data truncation and conversion error and add hex integer API To: , Ferruh Yigit , Andrew Rybchenko CC: , , , , , References: <20221208080540.62913-1-lihuisong@huawei.com> <20221219070648.33817-1-lihuisong@huawei.com> From: "lihuisong (C)" In-Reply-To: <20221219070648.33817-1-lihuisong@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.231] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600004.china.huawei.com (7.193.23.242) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ferruh and Andrew, This patch series optimizes some codes and bug. Can you take a look at this patch series? If there are no other questions, can it be merged? Best, Huisong 在 2022/12/19 15:06, Huisong Li 写道: > Some lib telemetry interfaces add the 'u32' and 'u64' data by the > rte_tel_data_add_dict/array_int API. This may cause data conversion > error or data truncation. This patch series uses 'u64' functions to > do this. > > In addition, this patch series introduces two APIs to store unsigned > integer values as hexadecimal encoded strings in telemetry library. > > --- > -v8: fix the coding style in patch 7/8 > -v7: replace sprintf with snprintf in patch 6/8 > -v6: fix code alignment to keep in line with codes in the file > -v5: > - drop a refactor patch. > - no limit the bit width for xxx_uint_hex API. > -v4: > - remove 'u32' value type.merg > - add padding zero for hexadecimal value > -v3: fix a misspelling mistake in commit log. > -v2: > - fix ABI break warning. > - introduce two APIs to store u32 and u64 values as hexadecimal > encoded strings. > > Huisong Li (8): > telemetry: move to header to controllable range > ethdev: fix possible data truncation and conversion error > mempool: fix possible data truncation and conversion error > cryptodev: fix possible data conversion error > mem: possible data truncation and conversion error > telemetry: support adding integer value as hexadecimal > test: add test cases for adding hex integer value API > ethdev: display capability values in hexadecimal format > > app/test/test_telemetry_data.c | 150 +++++++++++++++++++++++++++++ > lib/cryptodev/rte_cryptodev.c | 2 +- > lib/eal/common/eal_common_memory.c | 10 +- > lib/ethdev/rte_ethdev.c | 19 ++-- > lib/mempool/rte_mempool.c | 24 ++--- > lib/telemetry/rte_telemetry.h | 52 +++++++++- > lib/telemetry/telemetry_data.c | 73 ++++++++++++++ > lib/telemetry/version.map | 9 ++ > 8 files changed, 309 insertions(+), 30 deletions(-) >