From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 2BFCC1B180; Fri, 5 Oct 2018 21:57:21 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Oct 2018 12:57:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,345,1534834800"; d="scan'208";a="78831922" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49]) ([10.237.221.49]) by orsmga007.jf.intel.com with ESMTP; 05 Oct 2018 12:56:48 -0700 To: Jerin Jacob , John McNamara , Marko Kovacevic Cc: dev@dpdk.org, thomas@monjalon.net, arybchenko@solarflare.com, olivier.matz@6wind.com, stable@dpdk.org References: <20181005044606.27026-1-jerin.jacob@caviumnetworks.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: Date: Fri, 5 Oct 2018 20:56:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181005044606.27026-1-jerin.jacob@caviumnetworks.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] doc: clarify L3 Tx checksum prerequisite X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2018 19:57:22 -0000 On 10/5/2018 5:46 AM, Jerin Jacob wrote: > Based on PKT_TX_IP_CKSUM definition the user needs > to fill l2_len and l3_len mbuf fields before issuing > HW Tx checksum request. > > Fixes: dad1ec72a377 ("doc: document NIC features") > Cc: stable@dpdk.org > > Signed-off-by: Jerin Jacob > --- > > See PKT_TX_IP_CKSUM at > https://git.dpdk.org/dpdk/tree/lib/librte_mbuf/rte_mbuf.h#n283 > > --- > doc/guides/nics/features.rst | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst > index b085bda86..e726a6bb8 100644 > --- a/doc/guides/nics/features.rst > +++ b/doc/guides/nics/features.rst > @@ -562,6 +562,7 @@ Supports L3 checksum offload. > * **[uses] rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_IPV4_CKSUM``. > * **[uses] mbuf**: ``mbuf.ol_flags:PKT_TX_IP_CKSUM``, > ``mbuf.ol_flags:PKT_TX_IPV4`` | ``PKT_TX_IPV6``. > +* **[uses] mbuf**: ``mbuf.l2_len``, ``mbuf.l3_len``. Thanks this was missing. ``mbuf.l2_len``, ``mbuf.l3_len`` are required for TX CKSUM offload, in documentation there is no distinction for Rx or Tx, do you think does it worth to clarify PMD `uses` these values for Tx cksum offload only? > * **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_IP_CKSUM_UNKNOWN`` | > ``PKT_RX_IP_CKSUM_BAD`` | ``PKT_RX_IP_CKSUM_GOOD`` | > ``PKT_RX_IP_CKSUM_NONE``. >