From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4BC45A034C; Wed, 21 Sep 2022 09:58:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD7EB40697; Wed, 21 Sep 2022 09:58:58 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2075.outbound.protection.outlook.com [40.107.93.75]) by mails.dpdk.org (Postfix) with ESMTP id 40B754014F for ; Wed, 21 Sep 2022 09:58:57 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LEJSFSLPg0plgTb2v0JSc6W+e7wRGGTwBalzkv4wKEj+YYcU68AKuMIrJpxuLYdZYkW4jFFpdOrbTZj0cRFoJbSVjceUWz+IJkgvRDAz7a/Izr2CxNmS7QWCD2F4I7hGUji2rmyRXqs/3xu7FiYx0Tz2UticYp0EhfYRJa9gsfeL0grWZxoUNtFdBFfJLhISxmYAhaKYavfKodPH9CYQJ+oBAfI5pdSYV6DMo9Umy77YIzCMpouR13yJC+x4/GaPE746lcQUuMTVtMoJJRmefoieLybDgcLXRt5wiKpbnPZFVBX5x+8WoQ6nfb+labYD3FMOWN0mLnjrBfUV2LoNXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pKL5CGkMyiKvmHxOtsrqFRHhr+HFh+RC4q0AhuLLngg=; b=WNw+tTNxC4jGm6HU01uv+U3RsO79xvo/Q3Z/Zk84EAQOvqKTmy0K2PzxHvFUMzbm/mxu7foZfiCKTAU1Rnggles7ClKr4zWW3Bvcke7/kSo4PaafJcOq16bNhlK14iawao0J1hCOOUmoDkAnnDRbbVwSpGEyEIwRkoEu3WoR4x7jNZJHhsIq5qc95e/alfQiqoZl9rRMnNfa6FSzWuWiJBi97wmFJZd1NC51eDeWsOw8vCQCkLdc4gJRN54a3Udco04EW7Sepzl9hJWgmZwtfkBo3KNzZplSbNwBBmvJ2mVobS38aNzzdT14xYhjCwxqcIcLoq4Ys4+1FD/OzsSO3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=redhat.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pKL5CGkMyiKvmHxOtsrqFRHhr+HFh+RC4q0AhuLLngg=; b=oAAUQE0IDpeQIbush3ppc+6rIxuzt6CtBMecaCRSNRtvwtFEAufuuboXAITv62vz+dA+zmqvFOhhPMxgRTWVaH+QRQ/9ag9rSENdjsnuSUHFfa2/pwaE21nW3t256vfWZtwYWofntlDiiOvMuFWBqRzyfRzdTitSuLtM98GgiXY= Received: from DS7PR03CA0154.namprd03.prod.outlook.com (2603:10b6:5:3b2::9) by SA1PR02MB8368.namprd02.prod.outlook.com (2603:10b6:806:1f3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16; Wed, 21 Sep 2022 07:58:55 +0000 Received: from DM3NAM02FT028.eop-nam02.prod.protection.outlook.com (2603:10b6:5:3b2:cafe::8c) by DS7PR03CA0154.outlook.office365.com (2603:10b6:5:3b2::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16 via Frontend Transport; Wed, 21 Sep 2022 07:58:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; pr=C Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT028.mail.protection.outlook.com (10.13.4.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Wed, 21 Sep 2022 07:58:54 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 21 Sep 2022 08:58:53 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Wed, 21 Sep 2022 08:58:53 +0100 Envelope-to: rjarry@redhat.com, dev@dpdk.org, olivier.matz@6wind.com, bruce.richardson@intel.com Received: from [10.71.194.74] (port=55788) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oaudB-0002XT-Ek; Wed, 21 Sep 2022 08:58:53 +0100 Message-ID: Date: Wed, 21 Sep 2022 08:58:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v4] usertools: rewrite pmdinfo Content-Language: en-US To: Robin Jarry , CC: Olivier Matz , Bruce Richardson References: <20220913105811.84384-1-robin@jarry.cc> <20220920104212.476889-1-rjarry@redhat.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM3NAM02FT028:EE_|SA1PR02MB8368:EE_ X-MS-Office365-Filtering-Correlation-Id: fea566f9-fd8b-4998-6835-08da9ba7217f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WDIj6oXILUdcAWRPHsSTNd1F4GwPhJiupCKSx9aXVLbH3t+ha/juNavNAzWQEBTjziMnFco+YBSZpR9SVW9+b+wSXO7l/SSh/U/OAOkTYeK7IH8IbNoZ65SRMgbutdQRf+PI3IccjqIcUA17C2swrH5vNjjgWiu3Wen8UQwF4ejbJEtLAV+qXRJcds4yOAis+LP41jJ1QOMXFy5JsTYAqNCw41EBLzH3oT7PzjEoB/I9OaBAy3RK0kSEuMkJD4BiStkvClKWKzPNM1fy3fmTH/UZf4k1W6gtNSMSd6e5bmTjfxoWoN/awIXP3bjNEIUeoJH94UJFQsGJiEHkCqmdc7aeM2U/7PjKbldrw55ZPem9rwQZA3tCB1zedYrWcvnRcwkYHrSodaB5umBDvprZMuT/ZGl9ewz2gE0S0zOBbIuL13FM36oMt3NcLeD/r8U5roV2iLOdL2nS0cmYS3JFEVFCAjRQLuvABRmNg6/VvMTBOE4oJUnrtOvxBe3n5zyV5le+ial/txTK5egfKuQpbGhTyr9IW89oQclXU7xH6ftM2tBqhwdk1PhiIj4wkWNT9E4qvPeXALdmJx3Dess7+Dp0yB9Cj9/zpfbPf9DW30z/wSGxVht0uMDxBlus3IhCFhtzw6lg0D7n68N5Uq5I1dtcrrAONRkkzxw+J69WgbWTbjYHD7OlxbUGmXCBP2df7WNoRGlvooZT/VK1LMmE2QztEVlucESmxK+/pXFkTzoY+jPr1q8KJZOS26Sha1FqUbovnP9JoodwtsM63VYf5GNUo3+P6QdXNNTCpL4s9ms8z38MwzEWah7zzeELXEJMfPmBwdsjGDb72hndRC3Rog== X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230022)(4636009)(346002)(376002)(136003)(39860400002)(396003)(451199015)(36840700001)(46966006)(40470700004)(336012)(2616005)(426003)(47076005)(4744005)(82740400003)(356005)(7636003)(36860700001)(44832011)(5660300002)(9786002)(2906002)(41300700001)(8936002)(82310400005)(40480700001)(53546011)(478600001)(40460700003)(26005)(8676002)(4326008)(70206006)(70586007)(186003)(316002)(54906003)(110136005)(31686004)(36756003)(31696002)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2022 07:58:54.8000 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fea566f9-fd8b-4998-6835-08da9ba7217f X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT028.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR02MB8368 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/20/2022 8:15 PM, Robin Jarry wrote: > > Ferruh Yigit, Sep 20, 2022 at 19:48: >>> +* The ``dpdk-pmdinfo.py`` script was rewritten to produce valid JSON only. >>> + PCI-IDs parsing has been removed. >>> + To get a similar output to the (now removed) ``-r/--raw`` flag, you may use the following command:: >>> + >>> + strings $dpdk_binary_or_driver | sed -n 's/^PMD_INFO_STRING= //p' >>> >> >> Empty line is missing (in case there will be a new version for some >> other reason). > > What do you mean? > just nit picking, there needs to be two empty lines before "ABI Changes", I assume committer can fix it while merging if there won't be any new version.