From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Andrius Sirvys <andrius.sirvys@intel.com>,
dev@dpdk.org, Ravi Kumar <ravi1.kumar@amd.com>,
Rasesh Mody <rmody@marvell.com>,
Shahed Shaikh <shshaikh@marvell.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Alejandro Lucero <alejandro.lucero@netronome.com>,
Keith Wiles <keith.wiles@intel.com>
Cc: stable@dpdk.org, stephen@networkplumber.org, shaguna@chelsio.com,
rasesh.mody@qlogic.com, ophirmu@mellanox.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] drivers/net: fix shifting 32-bit signed variable 31 times
Date: Fri, 1 Mar 2019 17:18:25 +0000 [thread overview]
Message-ID: <d40c94ef-7b34-8bbb-5b85-db6ac2e173f4@intel.com> (raw)
In-Reply-To: <cdb49be3-c07a-da22-df2b-e912f8e3b927@intel.com>
On 2/26/2019 10:31 AM, Ferruh Yigit wrote:
> On 2/19/2019 1:24 PM, Andrius Sirvys wrote:
>> Shifting signed 32-bit values by 31-bits has the potential for
>> unexpected outcomes as compiler can overwrite a bit.
>> Specified that values are unsigned.
>>
>> Errors are observed from running cppcheck.
>>
>> Bugzilla ID: 58
>> Fixes: 69e209be5464 ("net/axgbe: add register map and related macros")
>> Fixes: b5bf7719221d ("bnx2x: driver support routines")
>> Fixes: ed2ced6fe927 ("net/bnxt: check initialization before accessing stats")
>> Fixes: 6fda3f0ddda9 ("net/cxgbe: add API to program hardware MPS table")
>> Fixes: bdb244b96920 ("e1000: whitespace changes")
>> Fixes: 5a32a257f957 ("e1000: more NICs in base driver")
>> Fixes: 2fe669f4bcd2 ("net/nfp: support MAC address change")
>> Fixes: defb9a5dd156 ("nfp: introduce driver initialization")
>> Fixes: ec94dbc57362 ("qede: add base driver")
>> Fixes: d2e7d931d0ad ("net/qede/base: formatting changes")
>> Fixes: cdc07e83bb24 ("net/tap: add eBPF program file")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2019-03-01 17:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 13:24 [dpdk-dev] " Andrius Sirvys
2019-02-26 10:31 ` Ferruh Yigit
2019-03-01 17:18 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d40c94ef-7b34-8bbb-5b85-db6ac2e173f4@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=alejandro.lucero@netronome.com \
--cc=andrius.sirvys@intel.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=ophirmu@mellanox.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=rasesh.mody@qlogic.com \
--cc=ravi1.kumar@amd.com \
--cc=rmody@marvell.com \
--cc=shaguna@chelsio.com \
--cc=shshaikh@marvell.com \
--cc=somnath.kotur@broadcom.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).