From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id DFF642BDD for ; Mon, 5 Dec 2016 15:37:49 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP; 05 Dec 2016 06:37:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,747,1477983600"; d="scan'208";a="908850179" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by orsmga003.jf.intel.com with ESMTP; 05 Dec 2016 06:37:47 -0800 To: Jingjing Wu , dev@dpdk.org References: <1480727953-92137-1-git-send-email-jingjing.wu@intel.com> <1480727953-92137-5-git-send-email-jingjing.wu@intel.com> Cc: helin.zhang@intel.com From: Ferruh Yigit Message-ID: Date: Mon, 5 Dec 2016 14:37:47 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1480727953-92137-5-git-send-email-jingjing.wu@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 04/31] net/i40e/base: fix bit test mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Dec 2016 14:37:50 -0000 On 12/3/2016 1:18 AM, Jingjing Wu wrote: > Incorrect bit mask was used for testing "get link status" response. > Instead of I40E_AQ_LSE_ENABLE (which is actually 0x03) it most probably most probably J > should be I40E_AQ_LSE_IS_ENABLED (which is defined as 0x01). > > Fixes: 8db9e2a1b232 ("i40e: base driver") This is detail, but defined syntax requires an empty line between "Fixes" tag and "Signed-off-by" tag. You will see /scripts/check-git-log.sh complain about it. > Signed-off-by: Jingjing Wu > --- > drivers/net/i40e/base/i40e_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c > index aa346d1..a2661cf 100644 > --- a/drivers/net/i40e/base/i40e_common.c > +++ b/drivers/net/i40e/base/i40e_common.c > @@ -1975,7 +1975,7 @@ enum i40e_status_code i40e_aq_get_link_info(struct i40e_hw *hw, > else > hw_link_info->crc_enable = false; > > - if (resp->command_flags & CPU_TO_LE16(I40E_AQ_LSE_ENABLE)) > + if (resp->command_flags & CPU_TO_LE16(I40E_AQ_LSE_IS_ENABLED)) > hw_link_info->lse_enable = true; > else > hw_link_info->lse_enable = false; >