DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] Suggestion to improve the code review
@ 2020-05-27  9:28 Jerin Kollanukkaran
  2020-05-27  9:59 ` Burakov, Anatoly
  2020-05-27 10:08 ` Gaëtan Rivet
  0 siblings, 2 replies; 9+ messages in thread
From: Jerin Kollanukkaran @ 2020-05-27  9:28 UTC (permalink / raw)
  To: dpdk-dev, Thomas Monjalon, david.marchand, Yigit, Ferruh,
	Maxime Coquelin, cristian.dumitrescu, akhil.goyal, rasland,
	xiaolong.ye, ajit.khaparde, arybchenko, Burakov, Anatoly
  Cc: techboard

I think, original discussion[1] on this topic got lost in GitHub vs current workflow.


I would like to propose GitHub "CODEOWNERS"[2] _LIKE_ scheme for DPDK workflow.

Current scheme:
- When we submit a patch to ml, someone(Tree maintainer[3]) needs to manually
delegate the patch to Tree maintainer in patchwork.
- Tree maintainer is not responsible for the review of the patch but only responsible
for merging _after_ the review. That brings the obvious question on review responsibility. 


Proposed scheme:
- In order to improve review ownership, IMO, it is better the CI tools delegate
the patch to the actual maintainer(who is responsible for specific code in MAINTAINERS file)
- I believe, it provides a sense of ownership, avoids last-minute surprise on
review responsibility and improve review traceability.

Implementation of the proposed scheme:
GitHub provides a bot for CODEOWNERS integration, Similar alternative is possible with
patchwork with "auto delegation scheme" using the flowing methods:

a) https://patchwork.readthedocs.io/en/latest/usage/delegation/
b) https://patchwork.readthedocs.io/en/latest/usage/headers/

I think, option (a) would be relatively easy to change without introducing the new tools.

Thoughts?

[1]
http://mails.dpdk.org/archives/dev/2020-May/168740.html
[2]
https://github.com/zephyrproject-rtos/zephyr/blob/master/CODEOWNERS
[3]
https://patchwork.dpdk.org/project/dpdk/


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-06-03 13:56 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-27  9:28 [dpdk-dev] Suggestion to improve the code review Jerin Kollanukkaran
2020-05-27  9:59 ` Burakov, Anatoly
2020-05-27 11:27   ` Jerin Jacob
2020-05-27 10:08 ` Gaëtan Rivet
2020-06-02 12:27   ` Jerin Jacob
2020-06-02 14:57     ` Ferruh Yigit
2020-06-02 16:23       ` Jerin Jacob
2020-06-03 13:09         ` Ferruh Yigit
2020-06-03 13:56           ` Jerin Jacob

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git