From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94D8A43003; Tue, 8 Aug 2023 00:32:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7172B40DFD; Tue, 8 Aug 2023 00:32:53 +0200 (CEST) Received: from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80]) by mails.dpdk.org (Postfix) with ESMTP id 7798240DDC for ; Tue, 8 Aug 2023 00:32:52 +0200 (CEST) Received: from debian (unknown [78.109.71.186]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by agw.arknetworks.am (Postfix) with ESMTPSA id E4D47E0F36; Tue, 8 Aug 2023 02:32:51 +0400 (+04) Date: Tue, 8 Aug 2023 02:32:44 +0400 (+04) From: Ivan Malov To: Xueming Li cc: Ori Kam , dev@dpdk.org Subject: Re: [PATCH] ethdev: add new symmetric hash function In-Reply-To: <20230807115456.17478-1-xuemingl@nvidia.com> Message-ID: References: <20230524113827.7351-1-xuemingl@nvidia.com> <20230807115456.17478-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Please see my notes below. On Mon, 7 Aug 2023, Xueming Li wrote: > The new symmetric hash function swap src/dst L3 address and > L4 ports automatically by sorting. > > Signed-off-by: Xueming Li > --- > lib/ethdev/rte_flow.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > index 86ed98c562..ec6dd170b5 100644 > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -3204,6 +3204,11 @@ enum rte_eth_hash_function { > * src or dst address will xor with zero pair. > */ > RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ, > + /** > + * Symmetric Toeplitz: src, dst will be swapped > + * automatically by sorting. This is very vague. Consider: For symmetric Toeplitz, four inputs are prepared as follows: - src_addr | dst_addr - src_addr ^ dst_addr - src_port | dst_port - src_port ^ dst_port and then passed to the regular Toeplitz function. It is important to be as specific as possible so that readers don't have to guess. Thank you. > + */ > + RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT, > RTE_ETH_HASH_FUNCTION_MAX, > }; > > -- > 2.25.1 > >