From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8074A41D3B; Wed, 22 Feb 2023 11:54:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6FDAD40693; Wed, 22 Feb 2023 11:54:01 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3D48840689 for ; Wed, 22 Feb 2023 11:54:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677063239; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1k3a+b5Pxq+JvgVCIbtX58WgukKWu9CNc1h4qFdQ/rY=; b=NtRPzV/EFQZR9dVOSzyrRErm/aqQ+gCXGDnoulQcGFWP0KcNrjf/WtvTbDGSxfiPtIg32Q bliZmRb+ZncfALsHukxunPHsh3JrIy8mf7ELL/qwuBQrUF/jzSaLv+9Q+JBS14LtRc0R77 QvgTRh0UvVJ0+olwQ8bqpFCeuUpS768= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-137-trq8NDcGP-GGkWigblGEbw-1; Wed, 22 Feb 2023 05:53:57 -0500 X-MC-Unique: trq8NDcGP-GGkWigblGEbw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F08DA884341; Wed, 22 Feb 2023 10:53:56 +0000 (UTC) Received: from [10.39.208.21] (unknown [10.39.208.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5665C2166B26; Wed, 22 Feb 2023 10:53:55 +0000 (UTC) Message-ID: Date: Wed, 22 Feb 2023 11:53:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 12/16] test/bbdev: remove check for invalid opaque data To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, stable@dpdk.org References: <20230215170949.60569-1-hernan.vargas@intel.com> <20230215170949.60569-13-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20230215170949.60569-13-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/15/23 18:09, Hernan Vargas wrote: > Assert also if the opaque data is invalid. New line needed before Fixes tag. > Fixes: 335c11fd276 ("app/bbdev: support HARQ validation") > Cc: stable@dpdk.org > > Signed-off-by: Hernan Vargas > --- > app/test-bbdev/test_bbdev_perf.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c > index a19eda2de8..2ce1c7e7d3 100644 > --- a/app/test-bbdev/test_bbdev_perf.c > +++ b/app/test-bbdev/test_bbdev_perf.c > @@ -79,7 +79,6 @@ > > #define SYNC_WAIT 0 > #define SYNC_START 1 > -#define INVALID_OPAQUE -1 > > #define INVALID_QUEUE_ID -1 > /* Increment for next code block in external HARQ memory */ > @@ -1999,10 +1998,9 @@ check_enc_status_and_ordering(struct rte_bbdev_enc_op *op, > "op_status (%d) != expected_status (%d)", > op->status, expected_status); > > - if (op->opaque_data != (void *)(uintptr_t)INVALID_OPAQUE) > - TEST_ASSERT((void *)(uintptr_t)order_idx == op->opaque_data, > - "Ordering error, expected %p, got %p", > - (void *)(uintptr_t)order_idx, op->opaque_data); > + TEST_ASSERT((void *)(uintptr_t)order_idx == op->opaque_data, > + "Ordering error, expected %p, got %p", > + (void *)(uintptr_t)order_idx, op->opaque_data); > > return TEST_SUCCESS; > } With typo fixed: Reviewed-by: Maxime Coquelin Thanks, Maxime