From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E91942A4F; Wed, 3 May 2023 15:47:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB83D4114B; Wed, 3 May 2023 15:47:47 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B102A41144 for ; Wed, 3 May 2023 15:47:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683121665; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=noYZGoQTPkFuBpGlhB2s27z4uY+rk+sBLmu0P/3yenA=; b=eXD9LfMt2uCApFq7kBih545o0Jhctq5oWMsc6tSnv+wOKnCpGKgiew95MesDZxZngNbd0d yAYF69JSkGDvD8iCiVODvj1SrnIwyXBRKGvTJsNGar95vHW6Im9zxBJtRVHjcQU1XYp2Zt XEwAL3l65zIrD7O5cIuh4bOzVc760Pc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-296-BLij8JRwMlyxXWw_he7_QA-1; Wed, 03 May 2023 09:47:43 -0400 X-MC-Unique: BLij8JRwMlyxXWw_he7_QA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5E8ADA0F386; Wed, 3 May 2023 13:47:43 +0000 (UTC) Received: from [10.39.208.36] (unknown [10.39.208.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2403D2026D16; Wed, 3 May 2023 13:47:40 +0000 (UTC) Message-ID: Date: Wed, 3 May 2023 15:47:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [RFC 07/27] vhost: change to single IOTLB cache per device To: "Xia, Chenbo" , "dev@dpdk.org" , "david.marchand@redhat.com" , "mkp@redhat.com" , "fbl@redhat.com" , "jasowang@redhat.com" , "Liang, Cunming" , "Xie, Yongji" , "echaudro@redhat.com" , "eperezma@redhat.com" , "amorenoz@redhat.com" References: <20230331154259.1447831-1-maxime.coquelin@redhat.com> <20230331154259.1447831-8-maxime.coquelin@redhat.com> From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chenbo, On 4/25/23 08:19, Xia, Chenbo wrote: > Hi Maxime, > >> -----Original Message----- >> From: Maxime Coquelin >> Sent: Friday, March 31, 2023 11:43 PM >> To: dev@dpdk.org; david.marchand@redhat.com; Xia, Chenbo >> ; mkp@redhat.com; fbl@redhat.com; >> jasowang@redhat.com; Liang, Cunming ; Xie, Yongji >> ; echaudro@redhat.com; eperezma@redhat.com; >> amorenoz@redhat.com >> Cc: Maxime Coquelin >> Subject: [RFC 07/27] vhost: change to single IOTLB cache per device >> >> This patch simplifies IOTLB implementation and improves >> IOTLB memory consumption by having a single IOTLB cache >> per device, instead of having one per queue. >> >> In order to not impact performance, it keeps an IOTLB lock >> per virtqueue, so that there is no contention between >> multiple queue trying to acquire it. >> >> Signed-off-by: Maxime Coquelin >> --- >> lib/vhost/iotlb.c | 212 +++++++++++++++++++---------------------- >> lib/vhost/iotlb.h | 43 ++++++--- >> lib/vhost/vhost.c | 18 ++-- >> lib/vhost/vhost.h | 16 ++-- >> lib/vhost/vhost_user.c | 25 +++-- >> 5 files changed, 160 insertions(+), 154 deletions(-) >> > > [...] > >> diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c >> index d60e39b6bc..81ebef0137 100644 >> --- a/lib/vhost/vhost_user.c >> +++ b/lib/vhost/vhost_user.c >> @@ -7,7 +7,7 @@ >> * The vhost-user protocol connection is an external interface, so it >> must be >> * robust against invalid inputs. >> * >> - * This is important because the vhost-user frontend is only one step >> removed >> +* This is important because the vhost-user frontend is only one step >> removed > > This is changed by accident? Yes, this will be fixed in v1. Thanks, Maxime > Thanks, > Chenbo