From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id C4EBA69FC for ; Wed, 11 Jan 2017 17:05:49 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 11 Jan 2017 08:05:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,346,1477983600"; d="scan'208";a="921376672" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by orsmga003.jf.intel.com with ESMTP; 11 Jan 2017 08:05:41 -0800 To: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , dev@dpdk.org References: <39ceb2bf1e5aa61e3957a8d8f9e5b2df28d6d2ad.1481590851.git.mirq-linux@rere.qmqm.pl> <1c4d6b329cb00fbed3d443800ed7eeb5b4bf57c7.1484127857.git.mirq-linux@rere.qmqm.pl> From: Ferruh Yigit Message-ID: Date: Wed, 11 Jan 2017 16:05:40 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1c4d6b329cb00fbed3d443800ed7eeb5b4bf57c7.1484127857.git.mirq-linux@rere.qmqm.pl> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] i40e: improve message grepability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2017 16:05:50 -0000 On 1/11/2017 9:49 AM, Michał Mirosław wrote: > Join message lines for easier grepping. > PRIxXX are left glued to strings as they are in other parts of the file. I can't apply this cleanly, would you mind rebasing on top of latest next-net? Also there is a minor nit below. Thanks, ferruh > > Signed-off-by: Michał Mirosław > > --- > drivers/net/i40e/i40e_ethdev.c | 308 +++++++++++++++++++++-------------------- > 1 file changed, 160 insertions(+), 148 deletions(-) > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c > index db2aebdb..00c15f87 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -764,8 +764,8 @@ i40e_add_tx_flow_control_drop_filter(struct i40e_pf *pf) > pf->main_vsi_seid, 0, > TRUE, NULL, NULL); > if (ret) > - PMD_INIT_LOG(ERR, "Failed to add filter to drop flow control " > - " frames from VSIs."); > + PMD_INIT_LOG(ERR, > + "Failed to add filter to drop flow control frames from VSIs."); Most messages aligned to "(", but single tab can give more room for the msg (4 more chars J), and tab is preferred one according DPDK coding convention. I don't have a strong opinion, what do you think? <...> > @@ -1788,8 +1789,8 @@ i40e_dev_start(struct rte_eth_dev *dev) > i40e_pf_enable_irq0(hw); > > if (dev->data->dev_conf.intr_conf.lsc != 0) > - PMD_INIT_LOG(INFO, "lsc won't enable because of" > - " no intr multiplex\n"); > + PMD_INIT_LOG(INFO, > + "lsc won't enable because of no intr multiplex\n"); Like this one is using tab. <...>