From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56447A055A; Mon, 5 Sep 2022 17:39:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4A789400D6; Mon, 5 Sep 2022 17:39:41 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2074.outbound.protection.outlook.com [40.107.243.74]) by mails.dpdk.org (Postfix) with ESMTP id 5EDCA40041 for ; Mon, 5 Sep 2022 17:39:39 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cMdKz/4ntmyI2/WFhON06aknmmDHk1kQMfuOp7aNH+nhi5UVxUj99YfAVDOb6Y+JH50x5lumjsf5Nft1H+mqJhQT1RmnVcl8Nz7SYZoEGFnJj63UzgeApJI5oQm2cYEcgeu8yh8FYhUV4zB0/FdkO8F4BhXprMvmXmeSiaCTwN2LdOlgOdgg4X7ND1mU86iBr0X8NSJ8P2hlcbsu9d5q0LXIkQtmgXUC0Y41rX8YPlFuWyrFeR4Jmc1zfyNlboAFTKPhrppodrL7rslHQ1BEgXEqgKhx1vImZKMjjXNCx1wt2BTDcZuXGLvIfEZWAOa0AwR9WX0MTkcVvQUxpWjImw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xfw5JunMW9MzJADXN1WYkUalrd50ofonOqPHHlIBcWA=; b=J1BzIs2KYE0ktiCV1ffVz4ynY6r/RVOAEPkOPzL3wzB1/LscX8nbPDqf9h9+6NBDv6HFbggFoXVD18ZP3UyNwt4pkfznCuvBRabi1jfxMY3fE3UMELbZUWuGnxO7wJHL011CEw0rTQO9C01HTiPa9XyHihBMhZxJcTku3KOpinhvj6PZoOcHoImkqBpQZjBmoCC8L1mxMzDCwdcpHQqTCXKK1pp6GCEHKtzTA/rBVA7jKghpF6pIHOIFooKgPFN3Js8iUAxCMb5/xjXcvwwH6vrWKFdU0r2fc/NA9ubdQ022ruXTOKMqGXWc4JNU1bvk8FcaJtfENWub/ZIy9iG6xA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=corigine.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xfw5JunMW9MzJADXN1WYkUalrd50ofonOqPHHlIBcWA=; b=pDLUNuowRpcxSOXUB+FmQNN9dTg9oB5yVDP9hJqYpqqUskUjwCY78XE7YZaFEBqAYnNzRBauEUi44BSzQJvqHMi2kOHst/0fLvAIpRZZ+3EL1T3871CaW1yo8ulHMT2VJdp8mo7rAWZUTmKvE8dBs1puoWEq9xpabf/Xtr8OQy8= Received: from SA9PR13CA0109.namprd13.prod.outlook.com (2603:10b6:806:24::24) by BYAPR02MB5767.namprd02.prod.outlook.com (2603:10b6:a03:11d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.17; Mon, 5 Sep 2022 15:39:36 +0000 Received: from SN1NAM02FT0006.eop-nam02.prod.protection.outlook.com (2603:10b6:806:24:cafe::80) by SA9PR13CA0109.outlook.office365.com (2603:10b6:806:24::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12 via Frontend Transport; Mon, 5 Sep 2022 15:39:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by SN1NAM02FT0006.mail.protection.outlook.com (10.97.5.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Mon, 5 Sep 2022 15:39:36 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 5 Sep 2022 16:39:35 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Mon, 5 Sep 2022 16:39:35 +0100 Envelope-to: chaoyong.he@corigine.com, dev@dpdk.org, oss-drivers@corigine.com, niklas.soderlund@corigine.com, heinrich.kuhn@corigine.com Received: from [10.71.194.74] (port=56535) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oVECE-0005kq-MG; Mon, 05 Sep 2022 16:39:35 +0100 Message-ID: Date: Mon, 5 Sep 2022 16:39:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v7 04/12] net/nfp: add initial flower firmware support Content-Language: en-US To: Chaoyong He , CC: , , Heinrich Kuhn References: <1660299750-10668-1-git-send-email-chaoyong.he@corigine.com> <1660299750-10668-5-git-send-email-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <1660299750-10668-5-git-send-email-chaoyong.he@corigine.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d6af47a9-1d48-43dc-d3bb-08da8f54d66e X-MS-TrafficTypeDiagnostic: BYAPR02MB5767:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: loZ+ZYzZoQavGwczcUysRmHBaGEYQUg3y+KjVAgIDTp3R0HkX3Wq3ue75JKjdfygwkBeyWTdPMrVtbx+lhk3D7UxDy8gmyCAYfhXYumRgxZyFs+ihJG3fFCZJm3rfh/Jh5V7iNZeic4ZgGOockbrc8hroi9AlW0A3pJPWv9S6Yard8XEqYFL+G38sD5gbFrnL/u5ebimDOhsVzSlMmWWyiNKt+D/ekqehmE/Oy+4gFcVZt4vQRzk9ZoUtlRkTL7htHzUAWNy1GowoEobFdtJhuVTE9gkgxAw+vrcU4QTPZQoMwg+SYMgzDD+j7x74C6m3jYsDbiffGKmT/X5BP8gV1RCGndh632gQwedTS2cX4DONZncVXCTtlQH9tJEM7spCqcLYiOUHVgqhiFJKA0Rg457goDi3kGVPm6agCjuE5T+o4am+aBkf5H5tIWECNc1Fk7zzPtfMMJFBsImP3s6Ww+DnkZ8RNyTom6fcm+Dke6kK1qiESnhyBjgjdJOdwr7cjDtc/yP7GTH8/uQ8S4ylDuFDA90gvmQm+f6q5WDnfr/RnUiRXiplPCrXDldt0cFKuQze0HiNIBgJM1oB41vgxyFgCJ2kH1uw/EX5MIrvrgALzsCuSHHtyoft5ygVb4GAR2Zbu6ZjQaijm3fkKDeByAOYrxiVwMUrt6XcNGgUZINjCHBR0dT3Y/c+5jG1Um2Kzr8czXyu2yIWMXOYcBGzvF7Z7xVq5oh+Uf1q04PsuOIDMOW/2dUuQVIryfjbJ25tANUjjscOyqRpzMDeO/G/EhpFhvZ/er7FTyAMdn5JLpyH+QUil8KCQHhMn/rNqCV X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(136003)(39860400002)(376002)(396003)(346002)(40470700004)(46966006)(36840700001)(36860700001)(54906003)(4326008)(70206006)(53546011)(5660300002)(316002)(82310400005)(2616005)(336012)(426003)(186003)(47076005)(41300700001)(40460700003)(8676002)(26005)(478600001)(4744005)(36756003)(70586007)(83380400001)(40480700001)(110136005)(44832011)(8936002)(356005)(2906002)(31696002)(9786002)(82740400003)(7636003)(31686004)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 15:39:36.1615 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d6af47a9-1d48-43dc-d3bb-08da8f54d66e X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0006.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR02MB5767 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/12/2022 11:22 AM, Chaoyong He wrote: > Adds the basic probing infrastructure to support the flower firmware. > This firmware is geared towards offloading OVS and can generally be > found in /lib/firmware/netronome/flower. It is also used by the NFP > kernel driver when OVS offload with TC is desired. '/lib/firmware/netronome/flower' FW is loaded (automatically ?) by kernel driver, right? Is there anything related to the DPDK with the name/path of the FW? And I wonder if these kind of information should be part of driver documentation? <...> > @@ -965,6 +968,16 @@ > goto hwqueues_cleanup; > } > break; > + case NFP_APP_FLOWER_NIC: > + PMD_INIT_LOG(INFO, "Initializing Flower"); > + pci_dev->device.driver = &pci_drv->driver; Why this assignment is required? Driver shouldn't need to update this bus related data struct.