From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3chas3@gmail.com> Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by dpdk.org (Postfix) with ESMTP id 2CFE61B454 for ; Tue, 27 Nov 2018 20:01:14 +0100 (CET) Received: by mail-qt1-f193.google.com with SMTP id p17so22989641qtl.5 for ; Tue, 27 Nov 2018 11:01:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=rmmkg4tH0qkDIc/08MwAUfS4pFxAzYLWAP2EkERLgUQ=; b=VXhon9/iGpFvpW/fEw8k63DOUIrDL6CIJhZQEx051LQjd2UQrnbHXv1d1y4w46MtMn EvPkmuQzLONrsd01tPTPdgk3bGAexNYYPQcsI7dyK3lgMg9VZP5WakNaqywCu2JRQstU TLCnOWdp9zhvN0exJ+RToE1IrV2RvDZnydku4F2mHIJchqIa1AnHSw2pZn5F9THotH2k XAqawbreBMAg41VyOaWvlrTx8I9O/6mRzCsoQAG0fKspmniggVWVCAX77lu4YbNkyUC6 qXe0aN6eo4zaF7VhOlXxMbMHEYc/+1o5IQFZwZUSMufrADxY5RUrviuZRgSNSe7r2EpN KlMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rmmkg4tH0qkDIc/08MwAUfS4pFxAzYLWAP2EkERLgUQ=; b=F3vpuw//PefmktdRlI7W0cqEhHTPHG/L5He/cF9cR30leJPvi0XlwMVXbFhceGbOCB qvrrMSARsJ0cWc3rzx2hVGB8sIUcgCpf+iDfe91gWmETUyh/q6IQl+Y79dCxotfnQ9Os mmVzSwaH9Hy3YvmUkGP2QLGNUumBdB8DU7Pbeyn9lbb2uXsgTGqmYQORCMGEDBfyKq1K oLAwvRkEg1VE6RzYnf+YYjXdtxcln+8aFmZJMq1BTvXsF9aIVDd4EUj2w7sMtkacm8Mi d8/bfxS4EmW+gu/vM0/HRKERg6915UP11UOnzxcoRDB57G1nCrXP2aCDBpiQsodhHmG4 SC/Q== X-Gm-Message-State: AA+aEWZBqi9DJMKZnf1jQa/qv22TVYFFuYFCI5Xclvvt4W0Z+Vij1fZ/ ceVDQrxMV9QtNLH0shYGBIcouzZx X-Google-Smtp-Source: AFSGD/V/+b+7OmXTRVpC/JZKaUdYWuketgoQjjwUS6KK1xVVAgttlmBCZGeEHsgX7YqtEhUVNK0vSQ== X-Received: by 2002:a0c:ad16:: with SMTP id u22mr32669423qvc.240.1543345273652; Tue, 27 Nov 2018 11:01:13 -0800 (PST) Received: from [192.168.1.10] (pool-96-255-82-34.washdc.fios.verizon.net. [96.255.82.34]) by smtp.gmail.com with ESMTPSA id y32sm2989206qth.3.2018.11.27.11.01.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Nov 2018 11:01:12 -0800 (PST) To: Radu Nicolau , dev@dpdk.org Cc: declan.doherty@intel.com, chas3@att.com References: <1542197949-15992-1-git-send-email-radu.nicolau@intel.com> From: Chas Williams <3chas3@gmail.com> Message-ID: Date: Tue, 27 Nov 2018 14:01:12 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1542197949-15992-1-git-send-email-radu.nicolau@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] examples/bond: wait for slaves to become active X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2018 19:01:14 -0000 On 11/14/2018 07:19 AM, Radu Nicolau wrote: > Do not start the packet processing threads until all configured > slaves become active. > > Signed-off-by: Radu Nicolau Acked-by: Chas Williams > --- > examples/bond/main.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/examples/bond/main.c b/examples/bond/main.c > index b282e68..6623cae 100644 > --- a/examples/bond/main.c > +++ b/examples/bond/main.c > @@ -220,6 +220,7 @@ bond_port_init(struct rte_mempool *mbuf_pool) > struct rte_eth_rxconf rxq_conf; > struct rte_eth_txconf txq_conf; > struct rte_eth_conf local_port_conf = port_conf; > + uint16_t wait_counter = 20; > > retval = rte_eth_bond_create("net_bonding0", BONDING_MODE_ALB, > 0 /*SOCKET_ID_ANY*/); > @@ -274,6 +275,20 @@ bond_port_init(struct rte_mempool *mbuf_pool) > if (retval < 0) > rte_exit(retval, "Start port %d failed (res=%d)", BOND_PORT, retval); > > + printf("Waiting for slaves to become active..."); > + while (wait_counter) { > + uint16_t act_slaves[16] = {0}; > + if (rte_eth_bond_active_slaves_get(BOND_PORT, act_slaves, 16) == > + slaves_count) { > + printf("\n"); > + break; > + } > + sleep(1); > + printf("..."); > + if (--wait_counter == 0) > + rte_exit(-1, "\nFailed to activate slaves\n"); > + } > + > rte_eth_promiscuous_enable(BOND_PORT); > > struct ether_addr addr; >