From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EDFBFA0548; Tue, 20 Apr 2021 13:36:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 700E141749; Tue, 20 Apr 2021 13:36:52 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 61EF741735 for ; Tue, 20 Apr 2021 13:36:50 +0200 (CEST) IronPort-SDR: SlYonNItKYWbN5NbsN9bFvijLNAUR9ZmCdXu9IL5vw+LxgXan/594poOPcHjV3dEKj0U6iMpHm HQ2RlaZSot3g== X-IronPort-AV: E=McAfee;i="6200,9189,9959"; a="195604066" X-IronPort-AV: E=Sophos;i="5.82,236,1613462400"; d="scan'208";a="195604066" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2021 04:36:45 -0700 IronPort-SDR: zv2rsayZwMbgGW+lnKI2wYSDc1GxiHWo6dBL+LPCYet8Fl6NaWMYITKKsgTd1JfXdFNpO7IA0H 0qwvXU6hLfhA== X-IronPort-AV: E=Sophos;i="5.82,236,1613462400"; d="scan'208";a="420374765" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.207.27]) ([10.213.207.27]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2021 04:36:43 -0700 To: Jiawei Wang , matan@nvidia.com, orika@nvidia.com, viacheslavo@nvidia.com, shahafs@nvidia.com Cc: dev@dpdk.org, thomas@monjalon.net, rasland@nvidia.com, roniba@nvidia.com References: <20210415092023.2089541-1-lizh@nvidia.com> <1618848506-37569-1-git-send-email-jiaweiw@nvidia.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Tue, 20 Apr 2021 12:36:39 +0100 MIME-Version: 1.0 In-Reply-To: <1618848506-37569-1-git-send-email-jiaweiw@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v9 0/2] Support meter policy API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/19/2021 5:08 PM, Jiawei Wang wrote: > Currently, the flow meter policy does not support multiple actions > per color; also the allowed action types per color are very limited. > In addition, the policy cannot be pre-defined. > > Due to the growing in flow actions offload abilities there is a potential > for the user to use variety of actions per color differently. > This new meter policy API comes to allow this potential in the most ethdev > common way using rte_flow action definition. > A list of rte_flow actions will be provided by the user per color > in order to create a meter policy. > In addition, the API forces to pre-define the policy before > the meters creation in order to allow sharing of single policy > with multiple meters efficiently. > > meter_policy_id is added into struct rte_mtr_params. > So that it can get the policy during the meters creation. > > Add two common policy template as macros in the header file, > > RFC ("ethdev: add pre-defined meter policy API") > https://patchwork.dpdk.org/project/dpdk/patch/20210318085815.804896-1-lizh@nvidia.com/ > > Depends-on: series=16351 ("Add ASO meter support in MLX5 PMD ") > https://patchwork.dpdk.org/project/dpdk/list/?series=16351 > > V2: Delete default policy and change relation doc files. > V3: Fix coding style issues. > V4: Fix comments about Depends-on > V5: Fix comments about rte_mtr_meter_policy_add. > V6: Delete policy example. > V7: Fix comments and place two common policy template as macros. > V8: Fix rebase conflict issues and CI warning > V9: Rebase and Fix the comments for softnic driver. > > Haifei Luo (1): > app/testpmd: support policy actions per color > > Li Zhang (1): > ethdev: add pre-defined meter policy API > Hi Li, Haifei, This patch conflicts with merged integrity check/conntrack features, also the dependent mlx5 ASO set send a new version. Can you please send a new version rebasing on latest versions?