From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 56A773777
 for <dev@dpdk.org>; Thu,  5 Jan 2017 15:04:41 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga103.jf.intel.com with ESMTP; 05 Jan 2017 06:04:39 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,321,1477983600"; d="scan'208";a="1108372880"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38])
 ([10.237.220.38])
 by fmsmga002.fm.intel.com with ESMTP; 05 Jan 2017 06:04:38 -0800
To: "Charles (Chas) Williams" <ciwillia@brocade.com>, dev@dpdk.org
References: <1483624424-2806-1-git-send-email-ciwillia@brocade.com>
Cc: linville@tuxdriver.com
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <d4d5c7f6-4700-6cf4-a264-3ec2ff30e280@intel.com>
Date: Thu, 5 Jan 2017 14:04:38 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <1483624424-2806-1-git-send-email-ciwillia@brocade.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2 1/4] net/af_packet: add iface name to
 internals
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Jan 2017 14:04:41 -0000

On 1/5/2017 1:53 PM, Charles (Chas) Williams wrote:
> This will be used by later changes to determine the underlying linux
> interface.
> 
> Signed-off-by: Charles (Chas) Williams <ciwillia@brocade.com>

Hi Charles,

Independent from the patch content,

it will be useful if you can send new patchset as reply to previous one,
this way all patches will be in same mail thread, this will help to
trace/review them, also it will be easier to find them in mail archive
in the future.

Another thing is, if you can add a version diff in the comment log,
after "---", that helps others to understand what has been changed in
this new version.

Thanks,
ferruh

<...>