DPDK patches and discussions
 help / color / mirror / Atom feed
From: Khoa To <khot@linux.microsoft.com>
To: Ranjit Menon <ranjit.menon@intel.com>
Cc: Khoa To <khot@linux.microsoft.com>,
	dev@dpdk.org, dmitry.kozliuk@gmail.com, pallavi.kadam@intel.com
Subject: Re: [dpdk-dev] [PATCH v4] bus/pci/windows: support for PCI scan allowed and blocked lists
Date: Wed, 3 Mar 2021 16:26:32 -0800 (PST)	[thread overview]
Message-ID: <d4fd3673-38c7-5e6d-237c-1fc6975a2e24@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <cd6d7070-7f3a-47f9-dff3-fa1548365dc8@intel.com>



On Wed, 3 Mar 2021, Ranjit Menon wrote:

> On 2/28/2021 10:52 PM, Khoa To wrote:
>>  EAL -a and -b options are used to specify which PCI devices are
>>  explicitly allowed or blocked during PCI bus scan.  This evaluation
>>  is missing in the Windows implementation of rte_pci_scan.
>>
>>  This patch provides this missing functionality, so that apps can specify
>>  which NetUIO devices to ignore during PCI bus scan.
>>
>>  Signed-off-by: Khoa To <khot@linux.microsoft.com>
>>  ---
>>  v4:
>>  * Fix coding style warning with unaligned comments
>>  v3:
>>  * Move the check inside pci_scan_one
>>  * Small change to pci_scan_one to malloc only after checks succeeded
>>  v2:
>>  * Truncate commit description lines to 75 charaters or less
>>
>>    drivers/bus/pci/windows/pci.c | 23 ++++++++++++++++-------
>>    1 file changed, 16 insertions(+), 7 deletions(-)
>> 
>
> This last change appears to be a formatting change. Was it required by 
> checkpatch?
>
> Other than that...
>
> Acked-by: Ranjit Menon <ranjit.menon@intel.com>
>

Thanks, Ranjit. Yes, v4 was just some white-space fixes for a CI warning.

  reply	other threads:[~2021-03-04  0:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-18  5:40 [dpdk-dev] [PATCH] " Khoa To
2021-02-18 18:40 ` [dpdk-dev] [PATCH v2] " Khoa To
2021-02-18 18:53   ` Ranjit Menon
2021-02-18 21:23     ` Dmitry Kozlyuk
2021-03-01  6:22   ` [dpdk-dev] [PATCH v3] " Khoa To
2021-03-01  6:52     ` [dpdk-dev] [PATCH v4] " Khoa To
2021-03-04  0:21       ` Ranjit Menon
2021-03-04  0:26         ` Khoa To [this message]
2021-03-04  7:14       ` Dmitry Kozlyuk
2021-03-16 21:35         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4fd3673-38c7-5e6d-237c-1fc6975a2e24@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
    --to=khot@linux.microsoft.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=pallavi.kadam@intel.com \
    --cc=ranjit.menon@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).