From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E2B90A0565;
	Thu,  4 Mar 2021 01:26:34 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 62AD540FDF;
	Thu,  4 Mar 2021 01:26:34 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 4A99740147
 for <dev@dpdk.org>; Thu,  4 Mar 2021 01:26:33 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1078)
 id 7F7F420B83EA; Wed,  3 Mar 2021 16:26:32 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7F7F420B83EA
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1614817592;
 bh=FhFQ6irq64unPs84DmneDuToghhhoXAva7e2mfpoB64=;
 h=Date:From:To:cc:Subject:In-Reply-To:References:From;
 b=goXkcqBCvlKYXNiUfF/mPrqp6kdJ6HSgJ6IDx32F+GJMCY92jIHie7STiLQHVIY7t
 4G5WP0vswFV0e9PR/JaGAY5pWEuQjS84+N2M3WGVwTCxhCHz+ZDhxkd6RJEjCl/i35
 FlAUlzPHaFGqz5F8/SkeRMSnbY7X7QoIjFQ6Kj/Q=
Received: from localhost (localhost [127.0.0.1])
 by linux.microsoft.com (Postfix) with ESMTP id 7E8C830705AD;
 Wed,  3 Mar 2021 16:26:32 -0800 (PST)
Date: Wed, 3 Mar 2021 16:26:32 -0800 (PST)
From: Khoa To <khot@linux.microsoft.com>
To: Ranjit Menon <ranjit.menon@intel.com>
cc: Khoa To <khot@linux.microsoft.com>, dev@dpdk.org, dmitry.kozliuk@gmail.com,
 pallavi.kadam@intel.com
In-Reply-To: <cd6d7070-7f3a-47f9-dff3-fa1548365dc8@intel.com>
Message-ID: <d4fd3673-38c7-5e6d-237c-1fc6975a2e24@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20210301062208.1904-1-khot@linux.microsoft.com>
 <20210301065241.237-1-khot@linux.microsoft.com>
 <cd6d7070-7f3a-47f9-dff3-fa1548365dc8@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Subject: Re: [dpdk-dev] [PATCH v4] bus/pci/windows: support for PCI scan
 allowed and blocked lists
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On Wed, 3 Mar 2021, Ranjit Menon wrote:

> On 2/28/2021 10:52 PM, Khoa To wrote:
>>  EAL -a and -b options are used to specify which PCI devices are
>>  explicitly allowed or blocked during PCI bus scan.  This evaluation
>>  is missing in the Windows implementation of rte_pci_scan.
>>
>>  This patch provides this missing functionality, so that apps can specify
>>  which NetUIO devices to ignore during PCI bus scan.
>>
>>  Signed-off-by: Khoa To <khot@linux.microsoft.com>
>>  ---
>>  v4:
>>  * Fix coding style warning with unaligned comments
>>  v3:
>>  * Move the check inside pci_scan_one
>>  * Small change to pci_scan_one to malloc only after checks succeeded
>>  v2:
>>  * Truncate commit description lines to 75 charaters or less
>>
>>    drivers/bus/pci/windows/pci.c | 23 ++++++++++++++++-------
>>    1 file changed, 16 insertions(+), 7 deletions(-)
>> 
>
> This last change appears to be a formatting change. Was it required by 
> checkpatch?
>
> Other than that...
>
> Acked-by: Ranjit Menon <ranjit.menon@intel.com>
>

Thanks, Ranjit. Yes, v4 was just some white-space fixes for a CI warning.