From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Nic Chautru <nicolas.chautru@intel.com>,
dev@dpdk.org, thomas@monjalon.net
Cc: trix@redhat.com, mdr@ashroe.eu, bruce.richardson@intel.com,
hemant.agrawal@nxp.com, david.marchand@redhat.com,
stephen@networkplumber.org, hernan.vargas@intel.com
Subject: Re: [PATCH v3 02/13] baseband/acc200: introduce PMD for ACC200
Date: Wed, 21 Sep 2022 09:17:44 +0200 [thread overview]
Message-ID: <d51eb785-cf64-777c-013a-e4049e0d3020@redhat.com> (raw)
In-Reply-To: <1663292106-45320-3-git-send-email-nicolas.chautru@intel.com>
On 9/16/22 03:34, Nic Chautru wrote:
> From: Nicolas Chautru <nicolas.chautru@intel.com>
>
> This patch introduce stubs for device driver for the ACC200
> integrated VRAN accelerator on SPR-EEC
>
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
> MAINTAINERS | 3 +
> doc/guides/bbdevs/acc200.rst | 244 +++++++++++++++++++++++++++++++
> doc/guides/bbdevs/index.rst | 1 +
> drivers/baseband/acc200/acc200_pmd.h | 32 ++++
> drivers/baseband/acc200/meson.build | 6 +
> drivers/baseband/acc200/rte_acc200_pmd.c | 142 ++++++++++++++++++
> drivers/baseband/acc200/version.map | 3 +
> drivers/baseband/meson.build | 1 +
> 8 files changed, 432 insertions(+)
> create mode 100644 doc/guides/bbdevs/acc200.rst
> create mode 100644 drivers/baseband/acc200/acc200_pmd.h
> create mode 100644 drivers/baseband/acc200/meson.build
> create mode 100644 drivers/baseband/acc200/rte_acc200_pmd.c
> create mode 100644 drivers/baseband/acc200/version.map
This is not how the common code sharing rework should be done. It does
not make sense to introduce acc200 directory in patch 2 to move it to
acc in patch 12.
The series must follow a logical path, by first refactoring acc100 to
share common code and then to add acc200 by making directly use of this
common code.
Regards,
Maxime
next prev parent reply other threads:[~2022-09-21 7:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 1:34 From: Nic Chautru <nicolas.chautru@intel.com> Nic Chautru
2022-09-16 1:34 ` [PATCH v3 01/13] baseband/acc100: refactor to segregate common code Nic Chautru
2022-09-21 7:13 ` Maxime Coquelin
2022-09-21 21:25 ` Chautru, Nicolas
2022-09-16 1:34 ` [PATCH v3 02/13] baseband/acc200: introduce PMD for ACC200 Nic Chautru
2022-09-21 7:17 ` Maxime Coquelin [this message]
2022-09-21 23:34 ` Chautru, Nicolas
2022-09-16 1:34 ` [PATCH v3 03/13] baseband/acc200: add HW register definitions Nic Chautru
2022-09-16 1:34 ` [PATCH v3 04/13] baseband/acc200: add info get function Nic Chautru
2022-09-16 1:34 ` [PATCH v3 05/13] baseband/acc200: add queue configuration Nic Chautru
2022-09-16 1:34 ` [PATCH v3 06/13] baseband/acc200: add LDPC processing functions Nic Chautru
2022-09-16 1:35 ` [PATCH v3 07/13] baseband/acc200: add LTE " Nic Chautru
2022-09-16 1:35 ` [PATCH v3 08/13] baseband/acc200: add support for FFT operations Nic Chautru
2022-09-16 1:35 ` [PATCH v3 09/13] baseband/acc200: support interrupt Nic Chautru
2022-09-16 1:35 ` [PATCH v3 10/13] baseband/acc200: add device status and vf2pf comms Nic Chautru
2022-09-16 1:35 ` [PATCH v3 11/13] baseband/acc200: add PF configure companion function Nic Chautru
2022-09-16 1:35 ` [PATCH v3 12/13] baseband/acc: rename and merge directories into acc Nic Chautru
2022-09-16 1:35 ` [PATCH v3 13/13] baseband/acc: simplify meson dependency Nic Chautru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d51eb785-cf64-777c-013a-e4049e0d3020@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=hernan.vargas@intel.com \
--cc=mdr@ashroe.eu \
--cc=nicolas.chautru@intel.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).