From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61740A034C; Wed, 21 Sep 2022 09:17:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32C42410D0; Wed, 21 Sep 2022 09:17:53 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C74CF4014F for ; Wed, 21 Sep 2022 09:17:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663744671; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2AIxkhq8OnJ/x0mssxzWxDWPohlWZILz+mkBc85NlfM=; b=CLORdAlhf0fg9hEKXMKffuoH93blyb66KVeB4dzJhuw6iAqtD14XzpeTzYthzk57b+ZurV 7xyy2upoRdL8lGJbFSAdhOPvhhjgTJS1WMXTeT6vpDYx+1dLuhO5BS4AhqqELrQV7slhWH xuI5UVKcoSwLAFSlOhksjgh36tnAuFY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-190-JzhxBxdOMLSl2bsHSHbW_A-1; Wed, 21 Sep 2022 03:17:48 -0400 X-MC-Unique: JzhxBxdOMLSl2bsHSHbW_A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 97BF1185A79C; Wed, 21 Sep 2022 07:17:47 +0000 (UTC) Received: from [10.39.208.16] (unknown [10.39.208.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AD9DE40C2064; Wed, 21 Sep 2022 07:17:45 +0000 (UTC) Message-ID: Date: Wed, 21 Sep 2022 09:17:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v3 02/13] baseband/acc200: introduce PMD for ACC200 To: Nic Chautru , dev@dpdk.org, thomas@monjalon.net Cc: trix@redhat.com, mdr@ashroe.eu, bruce.richardson@intel.com, hemant.agrawal@nxp.com, david.marchand@redhat.com, stephen@networkplumber.org, hernan.vargas@intel.com References: <1663292106-45320-1-git-send-email-nicolas.chautru@intel.com> <1663292106-45320-3-git-send-email-nicolas.chautru@intel.com> From: Maxime Coquelin In-Reply-To: <1663292106-45320-3-git-send-email-nicolas.chautru@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/16/22 03:34, Nic Chautru wrote: > From: Nicolas Chautru > > This patch introduce stubs for device driver for the ACC200 > integrated VRAN accelerator on SPR-EEC > > Signed-off-by: Nicolas Chautru > --- > MAINTAINERS | 3 + > doc/guides/bbdevs/acc200.rst | 244 +++++++++++++++++++++++++++++++ > doc/guides/bbdevs/index.rst | 1 + > drivers/baseband/acc200/acc200_pmd.h | 32 ++++ > drivers/baseband/acc200/meson.build | 6 + > drivers/baseband/acc200/rte_acc200_pmd.c | 142 ++++++++++++++++++ > drivers/baseband/acc200/version.map | 3 + > drivers/baseband/meson.build | 1 + > 8 files changed, 432 insertions(+) > create mode 100644 doc/guides/bbdevs/acc200.rst > create mode 100644 drivers/baseband/acc200/acc200_pmd.h > create mode 100644 drivers/baseband/acc200/meson.build > create mode 100644 drivers/baseband/acc200/rte_acc200_pmd.c > create mode 100644 drivers/baseband/acc200/version.map This is not how the common code sharing rework should be done. It does not make sense to introduce acc200 directory in patch 2 to move it to acc in patch 12. The series must follow a logical path, by first refactoring acc100 to share common code and then to add acc200 by making directly use of this common code. Regards, Maxime