From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f169.google.com (mail-wr0-f169.google.com [209.85.128.169]) by dpdk.org (Postfix) with ESMTP id 3CA125927 for ; Wed, 1 Mar 2017 13:50:14 +0100 (CET) Received: by mail-wr0-f169.google.com with SMTP id l37so29396130wrc.1 for ; Wed, 01 Mar 2017 04:50:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=cFoVoJvJU9WZYgEJ06A6Wpgm/DIXoG6mbZpWdmRMC3M=; b=pnhqTcRBUPsEuLKSjB7Crxk9CayPUsNmL7GYJISzRyud2kvm8Y3ScDJc5+lYKcoRZ/ 0Cil1K55WnmU+4ZlkIyIz3gVMOHtgylY4gPzazzrAXv9EXCopU4GAnWOlusHlJLAkXyb rfxkaYC1/BPWOXYBu81ob/pEr55rIV4CdOwoZcN+sWzLYtTAizK4HN2xnh7JBaXHuDDI NdcnKLksIA6WtZXlzbhnDSO2EZAfGXG4tlke9Gaf8YIWeOcvS8+c7ugJTF7BVfh+0Jaw 7d4v5j53DKwdnn0yap0T5Y+d5AmfMrHs8/ZNXjzmz9O7x+G0w9CMnCNypDwb+QAjr6cl TdeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=cFoVoJvJU9WZYgEJ06A6Wpgm/DIXoG6mbZpWdmRMC3M=; b=pUe9B5JuZvYQSHufOTSuaIbeetN+S3Un6v2yc7z8CK3CCpnoXRsgmplQSBaVW4juzt KN4XHKwcwfYJFRvqgn3huNm1tKxRzsH1ow9cxPU7sPx2NrulJKGs45bySPtHxYj1fuMB 0y2PbSpSGlkcYXq2p7Vc6+dMMXgIRvhruTHNgwSxLAsexpf0lg2FtAVeLVxhyXoDXu5Y uxx4RAm0sryRZnsAuyCI5TShbWPpgQcrT//PKU5HOT0M1tSVQ2yD6kegOhDkyOr1tzOM AIjbFtGcPx9k8zhVGwMXc8WN7wh7Ug05U5rp4301m6zrzv3ig1YiFbIN6SeZtpdad30F Motw== X-Gm-Message-State: AMke39nNszYnIG+KwmMNyhwY2t5h7JYLWXApWnmwPKH/kmFEr9tdTt5kE3f5sybSJ/5tfj9F X-Received: by 10.223.131.3 with SMTP id 3mr7198629wrd.153.1488372613932; Wed, 01 Mar 2017 04:50:13 -0800 (PST) Received: from ping.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id l45sm6502268wrc.14.2017.03.01.04.50.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 01 Mar 2017 04:50:13 -0800 (PST) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Adrien Mazarguil , stable@dpdk.org Date: Wed, 1 Mar 2017 13:49:40 +0100 Message-Id: X-Mailer: git-send-email 2.1.4 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH v2 1/9] net/mlx5: fix drop queue creation error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 12:50:14 -0000 Creating a drop queue in mlx5 ends by creating a non polled queue, but if the associated work queue could not be created the error was not handled ending in a undefined situation. Fixes: 2097d0d1e2cc ("net/mlx5: support basic flow items and actions") CC: stable@dpdk.org Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 23c1b5e..6765a77 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -902,6 +902,12 @@ priv_flow_create_action_queue(struct priv *priv, .pd = priv->pd, .cq = rte_flow->cq, }); + if (!rte_flow->wq) { + rte_flow_error_set(error, ENOMEM, + RTE_FLOW_ERROR_TYPE_HANDLE, + NULL, "cannot allocate WQ"); + goto error; + } } else { rxq = container_of((*priv->rxqs)[action->queue_id], struct rxq_ctrl, rxq); -- 2.1.4