From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBE63A0548; Thu, 1 Apr 2021 17:37:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5ADC9141016; Thu, 1 Apr 2021 17:37:53 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id D5CF8140F94 for ; Thu, 1 Apr 2021 17:37:51 +0200 (CEST) IronPort-SDR: PA9bvQUTodKKU76MSaZ2QSgtlpDPulf7syyWXvA6I39UUBm9deLSOjkp069AyLWatsHZpROK8k 3bKP5Y6L9OYQ== X-IronPort-AV: E=McAfee;i="6000,8403,9941"; a="179403335" X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="179403335" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 08:37:50 -0700 IronPort-SDR: TF/1mrJTkL/zfi8l43nsOng6FTl2UyzzJwNQAWMXSAA3kcydhf/CWKk0CcLf+3QobDLAUpUKGN 64FxlDq2MJRQ== X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="456035131" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.201.245]) ([10.213.201.245]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 08:37:48 -0700 To: "Min Hu (Connor)" , dev@dpdk.org Cc: thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru References: <1616830688-65506-1-git-send-email-humin29@huawei.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Thu, 1 Apr 2021 16:37:45 +0100 MIME-Version: 1.0 In-Reply-To: <1616830688-65506-1-git-send-email-humin29@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 0/3] fix miss input validation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/27/2021 7:38 AM, Min Hu (Connor) wrote: > The validity verification of input parameters should be performed at > API layer, not in the PMD. > > This set of patches fix miss input validation. > > Chengchang Tang (3): > ethdev: fix miss input validation in module EEPROM dump API > ethdev: fix miss input validation when access reg info > ethdev: fix miss input validation when access EEPROM info > The function updated in ethdev header file, and the ethdev .c file seems mixes within the patches [1], can you please send a new version to fix it, you can keep the acks to this version. [1] 1/3: * in .h: 'rte_eth_dev_get_module_info()', 'rte_eth_dev_set_eeprom()' * in .c: 'rte_eth_dev_get_module_info()', 'rte_eth_dev_get_module_eeprom()' 3/3: * in .h: 'rte_eth_dev_get_eeprom()', 'rte_eth_dev_get_module_eeprom()' * in .c: 'rte_eth_dev_get_eeprom()', 'rte_eth_dev_set_eeprom()'