From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3562A0487 for ; Wed, 3 Jul 2019 18:39:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 22007271; Wed, 3 Jul 2019 18:39:39 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 5CB47235; Wed, 3 Jul 2019 18:39:36 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2019 09:39:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,446,1557212400"; d="scan'208";a="158032314" Received: from klaatz-mobl1.ger.corp.intel.com (HELO [10.237.221.70]) ([10.237.221.70]) by orsmga008.jf.intel.com with ESMTP; 03 Jul 2019 09:39:34 -0700 To: Flavia Musatescu , dev@dpdk.org Cc: stable@dpdk.org, Reshma Pattan , ciara.power@intel.com, bruce.richardson@intel.com References: <1562077208-15355-1-git-send-email-flavia.musatescu@intel.com> <1562145823-18398-1-git-send-email-flavia.musatescu@intel.com> From: "Laatz, Kevin" Message-ID: Date: Wed, 3 Jul 2019 17:39:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1562145823-18398-1-git-send-email-flavia.musatescu@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v2] telemetry: fix build warnings seen when using gcc 9 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 03/07/2019 10:23, Flavia Musatescu wrote: > Suppress the unaligned packed member address warnings by extending > the telemetry library build flags with -Wno-address-of-packed-member > option, through the WERROR_FLAGS makefile variable. > > With this change additional warnings are turned on to be treated as errors, > which causes the following build issues to be seen: > - no previous prototype [-Werror=missing-prototypes] > - initialization discards ‘const’ qualifier from pointer target type > [-Werror=discarded-qualifiers] > - old-style function definition [-Werror=old-style-definition] > - variable may be used before its value is set (when using icc compiler). > > Fixes: 0fe3a37924d4 ("telemetry: format json response when sending stats") > Fixes: ee5ff0d3297e ("telemetry: add client feature and sockets") > Fixes: 8877ac688b52 ("telemetry: introduce infrastructure") > Fixes: 1b756087db93 ("telemetry: add parser for client socket messages") > Fixes: fff6df7bf58e ("telemetry: fix using ports of different types") > Fixes: 4080e46c8078 ("telemetry: support global metrics") > Cc: stable@dpdk.org > > Signed-off-by: Reshma Pattan > Signed-off-by: Flavia Musatescu > --- > Cc: ciara.power@intel.com > Cc: bruce.richardson@intel.com > Cc: reshma.pattan@intel.com > --- > lib/librte_telemetry/Makefile | 2 +- > lib/librte_telemetry/meson.build | 2 +- > lib/librte_telemetry/rte_telemetry.c | 19 ++++++------ > lib/librte_telemetry/rte_telemetry_internal.h | 4 +++ > lib/librte_telemetry/rte_telemetry_parser.c | 8 ++--- > lib/librte_telemetry/rte_telemetry_parser_test.c | 27 ++++++++-------- > lib/librte_telemetry/rte_telemetry_parser_test.h | 39 ------------------------ > 7 files changed, 33 insertions(+), 68 deletions(-) > delete mode 100644 lib/librte_telemetry/rte_telemetry_parser_test.h > LGTM, thanks! Acked-by: Kevin Laatz