From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DF5AA0548; Wed, 8 Jun 2022 10:57:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8020B40689; Wed, 8 Jun 2022 10:57:30 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 9E2344021D for ; Wed, 8 Jun 2022 10:57:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654678649; x=1686214649; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=LjOeHMtYpBuDneU/i85ezUSuRoXVxyq39YnlJ/bNi6I=; b=EQOUXk0oeEvi1nyq5oISvKoq7HF/pQ3d9BE/rRCJsTIjE4O/JC1DSSAU uso+wnaxZPZpAzc6uUmb3RsOZ1OlNy8PvdFiI8lrTKvbAZBZOozjBvdeE NjHd/1xsKZdDGkzYQQMCW7A+PKxsWRZ2bHXfSs/Ae5LSYtyhVHlDwFx0b PKD0PhjuYyq4Ly4Pxw713e5ZaUZmSorInZZgGYC2PTL/+MUcZ+oieqIx3 vb3mwB+p3W0vNUMdWCJnCIagxNe8VSFNsW6zrodFtEtqUN6PlxzjhRFE0 akrKKljSo2UXmTs478fEkRsnEF+/deoz0D1Z0hxG4QfeYaXaUNlyFLdIP A==; X-IronPort-AV: E=McAfee;i="6400,9594,10371"; a="265633910" X-IronPort-AV: E=Sophos;i="5.91,285,1647327600"; d="scan'208";a="265633910" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2022 01:57:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,285,1647327600"; d="scan'208";a="648494449" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 08 Jun 2022 01:57:27 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 8 Jun 2022 01:57:26 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 8 Jun 2022 01:57:26 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 8 Jun 2022 01:57:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IJsPIhiFqvK3o+uckDQIx3s6XgsB+e85+yG0OH4YNmNJADsz9M67LdgfCdDWVinzNvuum/Dbi0H/a+ymleN2gEUnqQqo4trm/OZkhflBfeedKM05cJV5kQSrPRKWOMEcjHRPWim4qrvteorr7sog3n9a6mCusF5OCmYN4F1Aat1+DtwoF5BhvddzwMFBmzSBdoNEenKVjMmcjxxL8X/BAM8sqv1LWbiEcRLVPBKvcXv5CopCMmeX4v05aduPaKuOclsVm0gYRxXs4ylG/QZEy0f3e2Hye8n1KbFBSMb8u679F5EMG1MWzBdpElddP7eg42Zlba90eV32tH4GeG6G3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LjOeHMtYpBuDneU/i85ezUSuRoXVxyq39YnlJ/bNi6I=; b=fq0MYp2TJQlYR1vBA3ezDkbLUJZtt2GaYLIxy0G3HaNzaImRzlKHebka1HNnsKE8dbqapa8cg31O/xczRotddO1wEBkU8zxvfVKrVFTZ0M3X5iUv+dfDf+aFT6pJ1CCUIuRzZ8xemooBaeFckU6wb+iwGZAZoPCyw+brYa7u+PDbZJCDN/GdYn8LgpaVRxp4KUWTQ3ZecohcSEnYviLpnkSqKE+1fKj9XT7NVEjOG3KJOzACefAR61NwXQ0LsqHWs3adNSvf7hv+MksCZ8qVM48EZ9H9/lb+r7uaRFCGdaej5T1bYlrM09x8ezG66+eXalws05Xb59Llwj6EPYNYYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by BN7PR11MB2545.namprd11.prod.outlook.com (2603:10b6:406:b0::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.19; Wed, 8 Jun 2022 08:57:24 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::24ae:1cd3:3192:4c7e]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::24ae:1cd3:3192:4c7e%5]) with mapi id 15.20.5314.019; Wed, 8 Jun 2022 08:57:24 +0000 Message-ID: Date: Wed, 8 Jun 2022 09:57:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] dma/idxd: fix return value for pci device commands To: Thomas Monjalon CC: "dev@dpdk.org" , "Richardson, Bruce" , "Walsh, Conor" References: <20220408141655.1320288-1-kevin.laatz@intel.com> <2240626.ElGaqSPkdT@thomas> From: Kevin Laatz In-Reply-To: <2240626.ElGaqSPkdT@thomas> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0376.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::21) To MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e2ccfc07-cbeb-4381-3d64-08da492ce7e2 X-MS-TrafficTypeDiagnostic: BN7PR11MB2545:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: joChlV2gS4dydvEjsAxqyxDsybTHzVTdNy6nrwuHxJId/PJq7aELHABYIrszuPQmsYElmY4tPVbyBK+x/dCn1liyrK32O6gc6azc4VursI0+xeubz31vVTFt+zgI/c+U0npaQXshyMYW+8Cd/Aq0VstWlZi9UL7IUWDkgNyeDLhoB8NVKepU36WFwGVxJqf0UIZ1ymbejkYhwtrLDRPkwJvknpnalITa3vRIlA54y8RxfH9bI2wTudWr8uimcFEZhV8mr6VPjRHLplP+VAwVT8JsjWlt6+RaA7xyR/kkGuIxdKV2XQiu7ydaInMjJ/GpNhpAI73mqOOk2X87nroL/o60n5ho8YFSdTvf+JrKs3lDX2xRyS5c/0glZ0y8XtSpZ9xIC2bF63RTsMbvaYFXxq3mz+lTiWe62MTLwfc7rDDlFCficKbjN2ZoboPo/UWhmulYErcn7+uMFJn/ye/OaQn/jSQPxsHrn9WIwD7RP/zT14jbIpsM1OpfL45LvRjyO958qMnvHgaiLrnoVPbIMgdAE/gIgWZcsBKgPiM6m3iz/FlUi9nxFVFLkpFkhTGR1153Z4vHdXcRJxZkIBlaJHwTx7ZQScGp4+CTjQbEmVf/DYVipqOv/0apToEvebAsTgAruKEsrlXAPcsK6ue9NoasQxuQBajR/pAWPl9CugZYA3m7mRxmYrObPLDFbrCBIXfRH7sS2do+g0TCt3U7BCo7JprcC8bQ9YlAkjhQFPE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB5872.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2906002)(8936002)(66556008)(6916009)(82960400001)(54906003)(66946007)(44832011)(38100700002)(107886003)(316002)(36756003)(5660300002)(26005)(31686004)(6512007)(6506007)(4326008)(8676002)(66476007)(53546011)(2616005)(6666004)(508600001)(4744005)(6486002)(186003)(31696002)(86362001)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NFJBc3pGY3dYYldGLzdCSEFEQkdpTFgvV254Ti9YVjFBdEt0a1d6VzdFTVJO?= =?utf-8?B?Z252RG9PMllFUG9HUFdtaTc0Qk5QeGtXaXdMNkJjdE0valZYdFBtbGRDWGMy?= =?utf-8?B?RTlpWHMzUnlvdDZlWEFlbmx3UDRUQ1Q4NVo5SzhEMjNJSWtCR0RjVDNUZnR5?= =?utf-8?B?MmRYS2o3ZDJ0eUpuM0hqVmJZTUQxakQyVThqd0lmS2ZPb2RuTlVBcHhLb3lq?= =?utf-8?B?MmYzaXlsNFlrU2g1WCtROEd0dlBtSjV3bHdOR2wxR3h5d1FYUHlDVnRWNkU5?= =?utf-8?B?RkJwVDk3Nmh2YXplQXFYWEVscUVoeElhbDdseVRaUjlmMDg4dnE5ODMzbXVa?= =?utf-8?B?Z3Rsa3FFTDZlN0pwZHQrSVFGR2RoUndMVVhyRVlPRzc0a2Fib0FGczBHajAx?= =?utf-8?B?NXA4NU1hRklnZGEzNllqV21USnR3cjNhWkZLaFUvaGw0SDNDMG52Qk41eStL?= =?utf-8?B?Q0JkNDMvcEV3bnBSZUQzSVlmdTJJVVpKVWJyUW9UMDVOYnBIYjY5dk9Sb1Jv?= =?utf-8?B?K2hpL2xITzgxNm4zUmVDZ3hrWmNrQ3A1Z1pZYVhoSE1ua1lFYitMdDZvSEZ0?= =?utf-8?B?L3JnK2dRQ1l0SVBUdzlHbWJUaitpUWZRSzdFV0VKdDdvZGx5cFdSL3JGUXdU?= =?utf-8?B?VGVJVGl0c3hmUUxVUTY5NGZkR2N1UjNnQVQ1bE1mcG1raVIzTWtaaURFczl3?= =?utf-8?B?Q0lBNEZxempGMDhPUUNMb2NTYXdaMDJuOEQ3cmcreEo0cEh1MW1zMmZCeDgx?= =?utf-8?B?Um8yam00dmNMUEV6VUswMVl6WGtSMHRtSXo3ZUVRZlkvWnNwelpteXVsY0Vs?= =?utf-8?B?MTcrTytEYUtWbEdjVlYwVGp5SXJQMXgxb0ZxOU1JRndkOE44SDBKUGt1KzUr?= =?utf-8?B?ZGFhcnZOcFB0Q0ZUS2xEdUw3T0dNOVVLQ0VLS1dwb010UGVpZWZUY3EwdDVi?= =?utf-8?B?cVdsalhZL25mUFNBbG9ZWFU2Z3p2MThwQ1VHVE85TnBXcE5LU044T2xkVGsy?= =?utf-8?B?c2F2NVFGQTl1QkN2NGVJRHc3eFAzNHpJeEJFQzhqQmFPZVo0aDl1Q3JYQnFs?= =?utf-8?B?WnIrYThBMVhraGhIWVFvbUxtVjI1WTZON3ppbjBjSGlGS0wyT1o4QmJhRUpC?= =?utf-8?B?eTVINTdZNEZSdm81MEFROGxEdzZzRlMvNHpuSWdUdG5YTXlaWmpVMnl1eDJv?= =?utf-8?B?WlpxTTh4V3NpTXBxZjBmMGdjQ1ArSHU0WXcyRW9hK1lEaHhydWYxTjdhbWxt?= =?utf-8?B?Rkg3ZWdObVJ0eHczM1NkSE5sRUN3UmNTNngvMFowWDV0blRVYjVTNjMwNTNF?= =?utf-8?B?SU9HSURoUnBTTy9IVXkwbFE2TEpBZ3pqU1l0cUJHbWc1WVU2b3ArM0hOTC9D?= =?utf-8?B?a29ic2lrNzNtUC9WQi9VN0UrT0FaTHNYVndOQzUyMytOcGd6TDg3VlRMdXNx?= =?utf-8?B?a2lNSm4yREI4czUvNlR3ODM2S2lBbWM2MTVHL2s2UXM4REFhbmdkMkI1d2My?= =?utf-8?B?QVJJOWtwaFRLMERseHh0NmpYVkRkRnJZY1RMOUVBRFBwREFKaExjWTQwREJq?= =?utf-8?B?YmhSUzBWNnVvNW85WkJaeWtzTkZYWWZJakFLVDJ5UWJaMndhQ1B2NFI5ekNR?= =?utf-8?B?T0NZTUYzZk5SendmQzRkYmxDSW85d3gyMldPL2tQT0tucTBiMDJ5dm90RDlF?= =?utf-8?B?dFNCbkFCMGw5bHlXdGlsYjlLZGNSeFF5bGFZcHhsNmpVQkNXaVhyQjhEa0M0?= =?utf-8?B?cGUzaENWc3c4YW5zZ29MdERmNXh3SU9nYnJJZldzYXQ2cy85V3R5TXkxQXVB?= =?utf-8?B?MDZyZXdscnlUR3d4eERYczYvenovREdhZll6QjhuYk9BQzNVWVowcXVEL2hJ?= =?utf-8?B?YTI5TGx0U3dScStIRGFaUDVtczBaanBvdmVpVWdPdmI4SWNSbEViNzB3K2lq?= =?utf-8?B?WFVGbFZqKyswTTF2ZC9kdjRVMG1SZzdWM0tSeFZEblczM05FTXpNQldCVWZ0?= =?utf-8?B?Y0RYRlhKejQ4bDJ5cUVWb0crQjB2M1BBYTZOTnhYbXRyeU8yWCtmWmJPejhv?= =?utf-8?B?UHM3SXlrTnRWNGVBTlpzeEZDZUoyOFl2YWhJWU1KN3lpRE02LzN0VElXeG1I?= =?utf-8?B?bjFkcE02SHM2SjlqWU5JNGx2LzkzRHV5bndjYlQzYng0M3QwM1lIZTNwZCt3?= =?utf-8?B?dlJIdm93SCtmS01zRTJRa3ViRjVlekRLTWdyTnNLUHZtU1lQaTdNb25qSmUv?= =?utf-8?B?WmFFRiszZ1dqSU9RU1hXclV2eE9KVWF0M0M0MnZaS1ltYS9kYzQ1LzJXRzlD?= =?utf-8?B?TjlIZ2dqZjJwRlFCUnhjQ1EyOHdDdFJBR1pQbWI5TXJIVm5HcjljYUh3a1hB?= =?utf-8?Q?FLmgmguRc+deL+34=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: e2ccfc07-cbeb-4381-3d64-08da492ce7e2 X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2022 08:57:24.6754 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R6oOLvzVBBK/fFFz6PibfpBi4Wqk7ZVcRKWQaMeWzPqLyXhUENCXy8StxDxJKYjxBZynQ/yzgrlDiD4fSe+oCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2545 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 08/06/2022 09:54, Thomas Monjalon wrote: > 07/06/2022 12:56, Walsh, Conor: >>> Subject: [PATCH] dma/idxd: fix return value for pci device commands >>> >>> When sending a command to an idxd device via pci bar, the response from >>> HW is checked to ensure it was successful. The response was incorrectly >>> being negated before being returned by the function, meaning error codes >>> cannot be checked against the HW specification. >>> >>> This patch fixes the return values of the function by removing the >>> negation. >>> >>> Signed-off-by: Kevin Laatz >> Acked-by: Conor Walsh > Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe") > Fixes: 452c1916b0db ("dma/idxd: fix truncated error code in status check") > Cc: stable@dpdk.org > > Please don't forget above lines in future. > > Applied, thanks. > That was an oversight, thanks for adding!